Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt at implementing clients for Pub/Sub #910

Merged
merged 15 commits into from
Jun 17, 2015
Merged

Attempt at implementing clients for Pub/Sub #910

merged 15 commits into from
Jun 17, 2015

Commits on Jun 5, 2015

  1. Adding basic client class in pubsub. 

    Allows implicit determination of project and credentials
if no values are passed.
    @dhermes
    dhermes committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    4bf5c05 View commit details
    Browse the repository at this point in the history

  2. Adding factory constructors to pubsub client.

    @dhermes
    dhermes committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    12460a9 View commit details
    Browse the repository at this point in the history

  3. Implementing Client.list_topics in pubsub.

    @dhermes
    dhermes committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    f058b3e View commit details
    Browse the repository at this point in the history

  4. Implementing Client.list_subscriptions in pubsub.

    @dhermes
    dhermes committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    47cc25a View commit details
    Browse the repository at this point in the history

  5. Allowing client to be used in pubsub.Topic.

    @dhermes
    dhermes committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    be42839 View commit details
    Browse the repository at this point in the history

  6. Removing gcloud.pubsub.api.

    @dhermes
    dhermes committed Jun 5, 2015
    Configuration menu
    Copy the full SHA
    ce34ef3 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2015

  1. Making Topic.from_api_repr accept a client. 

    Also moving Topic.client -> Topic._client since it
should not (maybe?) be user facing.

Also ditching use of actual Client class in test_topic
and just using a mock (this simplifes things a bit).
    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    e187345 View commit details
    Browse the repository at this point in the history

  2. Adding client to Subscription.from_api_repr. 

    This is so that it can be passed through to the parent topic
created with the subscription.
    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    d9e3dc3 View commit details
    Browse the repository at this point in the history

  3. Making client mandatory in most of pubsub. 

    In particular, in the Topic constructor and in
Topic.from_api_repr and Subscription.from_api_repr.
    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    8360e69 View commit details
    Browse the repository at this point in the history

  4. Using client on all Topic methods. 

    Ditching use of connection since client already
contains this information.
    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    a1a19a3 View commit details
    Browse the repository at this point in the history

  5. Using client on all Subscription methods. 

    Ditching use of connection since client already
contains this information.
    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    d8626ef View commit details
    Browse the repository at this point in the history

  6. Removing unused implict code in pubsub.

    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    ff39a92 View commit details
    Browse the repository at this point in the history

  7. Updating pubsub regression test for new code.

    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    805225b View commit details
    Browse the repository at this point in the history

  8. Updating Pub/Sub docs based on client changes.

    @dhermes
    dhermes committed Jun 6, 2015
    Configuration menu
    Copy the full SHA
    29f35d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2015

  1. Addressing review comments in PR googleapis#910. 

    In particular:
- Renaming `with_service_...` methods to `from_service_...` on
  `pubsub.Client`.
- Updating docstring for `http` on `pubsub.Client` to describe the
  default behavior when no value is passed.
- Making `client` a required / positional argument in `pubsub.Topic`
  (and ditching a test in the process).
- Renaming `test_make_topic` as `test_topic`.
    @dhermes
    dhermes committed Jun 17, 2015
    Configuration menu
    Copy the full SHA
    c206638 View commit details
    Browse the repository at this point in the history