Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix broken links for Core, DNS, Language, RuntimeConfig and WebRisk #9148

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Docs: Fix broken links for Core, DNS, Language, RuntimeConfig and WebRisk #9148

merged 1 commit into from
Sep 3, 2019

Conversation

ryanyuan
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019
@ryanyuan ryanyuan changed the title Fix broken links for Core, DNS, Language, RuntimeConfig and WebRisk Docs: Fix broken links for Core, DNS, Language, RuntimeConfig and WebRisk Aug 30, 2019
@plamut plamut added type: docs Improvement to the documentation for an API. api: core api: dns Issues related to the Cloud DNS API. api: language Issues related to the Cloud Natural Language API API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: webrisk Issues related to the Web Risk API. labels Aug 30, 2019
plamut
plamut reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the new links does not work, but it might be the link that needs to be updated to match the proposed change in the README file.

The rest looks good, thanks for the PR!

language/README.rst Outdated Show resolved Hide resolved
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@tseaver tseaver merged commit 10cc8a8 into googleapis:master Sep 3, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
@ryanyuan @emar-kar
Fix broken links in docs. (googleapis#9148)
0172589
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@ryanyuan @emar-kar
Fix broken links in docs. (googleapis#9148)
d6b1d12
parthea pushed a commit that referenced this pull request Jun 4, 2023
@ryanyuan @tseaver
Fix broken links in docs. (#9148)
eb8ef8a
parthea pushed a commit that referenced this pull request Jul 6, 2023
@ryanyuan @tseaver
Fix broken links in docs. (#9148)
95953a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: core api: dns Issues related to the Cloud DNS API. api: language Issues related to the Cloud Natural Language API API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: webrisk Issues related to the Web Risk API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ryanyuan @plamut @busunkim96 @tseaver @googlebot @yoshi-kokoro