Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Change default endpoint to bigquery.googleapis.com #9213

Merged
merged 2 commits into from
Sep 13, 2019
Merged

BigQuery: Change default endpoint to bigquery.googleapis.com #9213

merged 2 commits into from
Sep 13, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 added the api: bigquery Issues related to the BigQuery API. label Sep 11, 2019
@busunkim96 busunkim96 requested a review from a team September 11, 2019 18:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2019
plamut
plamut reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references to www.googleapis... in client.py, model.proto, and snippets.py (and model_pb2.py, but that's generated from the .proto file).

I suppose the PR should update those, too?

@busunkim96
Copy link
Contributor Author

@plamut Thank you! I will take another look. We've been asked to switch the default endpoint. Some references to www.googleapis.com are for auth, so those will stay the same.

The generated portions of the client should get the change automatically with a proto update. I assumed that had already happened, but I guess not yet? 🤔

plamut
plamut approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 Ah, in that case it looks good. All remaining www.googleapis... URLs are related to auth, thanks for explaining.

@busunkim96 busunkim96 merged commit c21ec23 into googleapis:master Sep 13, 2019
@busunkim96 busunkim96 deleted the bigquery-endpoint branch September 13, 2019 18:21
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96 @emar-kar
Change default endpoint to bigquery.googleapis.com (googleapis#9213)
6f26e76
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96 @emar-kar
Change default endpoint to bigquery.googleapis.com (googleapis#9213)
0556f1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@tswast tswast tswast approved these changes

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@busunkim96 @tseaver @tswast @plamut @googlebot