Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(translation): add VPC-SC system tests #9272

Merged
merged 9 commits into from Oct 9, 2019

Conversation

pkumusic
Copy link

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2019
@busunkim96 busunkim96 changed the title Translation: Add VPC-SC system tests. test(translation): add VPC-SC system tests Sep 23, 2019
@busunkim96 busunkim96 added the api: translation Issues related to the Cloud Translation API API. label Sep 23, 2019
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2019
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the updates!

The build should turn green once you run the code formatter: nox -s blacken from the translate/ directory.

If you do not have nox installed, you can get it with python3 -m pip install nox.

@busunkim96
Copy link
Contributor

There are a few more linter errors:

flake8 google tests
tests/system/test_vpcsc.py:23:1: F401 'google.cloud.translate_v3beta1.proto.translation_service_pb2' imported but unused
tests/system/test_vpcsc.py:24:1: F401 'google.longrunning.operations_pb2' imported but unused
tests/system/test_vpcsc.py:85:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:90:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:102:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:105:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:115:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:116:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:124:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:127:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:143:9: E731 do not assign a lambda expression, use a def
tests/system/test_vpcsc.py:150:9: E731 do not assign a lambda expression, use a def

@pkumusic
Copy link
Author

pkumusic commented Oct 9, 2019

Hi Bu Sun, looks like all checks passed. Can we merge the pull requests?

Best,
Music

@busunkim96 busunkim96 merged commit 6f1d68f into googleapis:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: translation Issues related to the Cloud Translation API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants