Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(bigquery): add code samples to lint check #9277

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Sep 24, 2019

Closes #9081.

This PR makes sure that the code samples, too, undergo the lint check (flake8 specifically, as black already checks the samples).

After experimenting with the synth tool a bit, I realized that the BigQuery's noxfile is not generated by synth from the template, thus modified it directly.

How to test

Introduce a few flake8-specific (i.e. not relevant to black) lint errors to some of the files in docs/samples, such as an unused import, and run the lint check:

$ nox -f noxfile.py -s lint

Actual result (before the fix):
The check passes despite the lint issues.

Expected result (before the fix):
The check correctly fails and complains about the lint issues.

@plamut plamut added api: bigquery Issues related to the BigQuery API. type: cleanup An internal cleanup or hygiene concern. labels Sep 24, 2019
@plamut plamut requested a review from a team September 24, 2019 09:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2019
@tswast tswast merged commit c037a51 into googleapis:master Sep 26, 2019
@plamut plamut deleted the iss-9081 branch September 27, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Run lint and black on samples/ directory
3 participants