Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): add 'StreamingPullManager._should_terminate'. #9335

Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix(pubsub): add 'StreamingPullManager._should_terminate'. #9335

merged 1 commit into from
Oct 1, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 27, 2019

Toward clean shutdown of the subscriber's background thread.

See: #8616.

@tseaver
fix(pubsub): add 'StreamingPullManager._should_terminate'.
df80e7b 
Toward clean shutdown of the subscriber's background thread.

See: #8616.
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Sep 27, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2019
plamut
plamut approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It does not fix the issue yet, but the PR description does not claim that.

@tseaver tseaver merged commit bbd09fd into googleapis:master Oct 1, 2019
@tseaver tseaver deleted the pubsub-add-should_terminate branch October 1, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @plamut @googlebot