Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(videointelligence): make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth) #9440

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/videointelligence/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:0d2f8d429110aeb8d82df6550ef4ede59d40df9062d260a1580fce688b0512bf
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1beta2.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta2.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1beta2/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta2/google/cloud/videointelligence_v1beta2/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1beta2/google/cloud/videointelligence_v1beta2/proto.
synthtool > Replaced 'google-cloud-video-intelligence' in google/cloud/videointelligence_v1beta2/gapic/video_intelligence_service_client.py.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1p1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1p1beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p1beta1/google/cloud/videointelligence_v1p1beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p1beta1/google/cloud/videointelligence_v1p1beta1/proto.
synthtool > Replaced 'google-cloud-video-intelligence' in google/cloud/videointelligence_v1p1beta1/gapic/video_intelligence_service_client.py.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1p2beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p2beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1p2beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p2beta1/google/cloud/videointelligence_v1p2beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p2beta1/google/cloud/videointelligence_v1p2beta1/proto.
synthtool > Replaced 'google-cloud-video-intelligence' in google/cloud/videointelligence_v1p2beta1/gapic/video_intelligence_service_client.py.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1p3beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p3beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1p3beta1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p3beta1/google/cloud/videointelligence_v1p3beta1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1p3beta1/google/cloud/videointelligence_v1p3beta1/proto.
synthtool > Replaced 'google-cloud-video-intelligence' in google/cloud/videointelligence_v1p3beta1/gapic/streaming_video_intelligence_service_client.py.
synthtool > Replaced 'google-cloud-video-intelligence' in google/cloud/videointelligence_v1p3beta1/gapic/video_intelligence_service_client.py.
synthtool > Running generator for google/cloud/videointelligence/artman_videointelligence_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/videointelligence/v1/video_intelligence.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1/google/cloud/videointelligence_v1/proto/video_intelligence.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/video-intelligence-v1/google/cloud/videointelligence_v1/proto.
synthtool > Replaced 'google-cloud-video-intelligence' in google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1beta2/test_video_intelligence_service_client_v1beta2.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1p3beta1/test_video_intelligence_service_client_v1p3beta1.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1p2beta1/test_video_intelligence_service_client_v1p2beta1.py.
synthtool > Replaced '^(\\s+)expected_request = video_intelligence_pb2.AnnotateVideoRequest\\(\\)' in tests/unit/gapic/v1p1beta1/test_video_intelligence_service_client_v1p1beta1.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1beta2/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/streaming_video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/streaming_video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/transports/streaming_video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p1beta1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/transports/video_intelligence_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/video_intelligence_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/gapic/video_intelligence_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/proto/video_intelligence_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1/test_video_intelligence_service_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p2beta1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1beta2/test_video_intelligence_service_client_v1beta2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p1beta1/test_video_intelligence_service_client_v1p1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p2beta1/test_video_intelligence_service_client_v1p2beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p3beta1/test_streaming_video_intelligence_service_client_v1p3beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/tests/unit/gapic/v1p3beta1/test_video_intelligence_service_client_v1p3beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/videointelligence/google/cloud/videointelligence_v1p3beta1/proto/video_intelligence_pb2.py
All done! ✨ 🍰 ✨
53 files reformatted, 18 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: videointelligence Issues related to the Video Intelligence API API. label Oct 10, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2019
@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated videointelligence to pick up changes in the API or client library generator. fix(videointelligence): make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth) Oct 10, 2019
@tseaver
Copy link
Contributor

tseaver commented Oct 10, 2019

@busunkim96 Making features required seems like a breaking change: also, I can't see a corresponding change to the .proto file which drives it.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 10, 2019
@busunkim96 busunkim96 changed the title fix(videointelligence): make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth) fix(videointelligence)!: make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth) Oct 10, 2019
@tseaver
Copy link
Contributor

tseaver commented Oct 10, 2019

Artman is creating a failing unit test here, TestVideoIntelligenceServiceClient.test_annotate_video.

@busunkim96 busunkim96 changed the title fix(videointelligence)!: make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth) fix(videointelligence): make features a positional parameter in annotate_video, update retry config, make AnnotateVideo nonidempotent (via synth) Oct 10, 2019
@tswast tswast requested review from tswast and removed request for tswast October 18, 2019 23:15
@busunkim96 busunkim96 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2019
@busunkim96 busunkim96 merged commit 9fd07ec into master Oct 28, 2019
busunkim96 added a commit to busunkim96/google-cloud-python that referenced this pull request Nov 14, 2019
…r in `annotate_video`, update retry config, make AnnotateVideo nonidempotent (via synth) (googleapis#9440)"

This reverts commit 9fd07ec.
busunkim96 added a commit that referenced this pull request Nov 15, 2019
…eter (#9810)

* Makes `features` a keyword parameter to annotate_video

This reverts part of commit 9fd07ec.
parthea pushed a commit that referenced this pull request Sep 22, 2023
…notate_video`, update retry config, make AnnotateVideo nonidempotent (via synth) (#9440)
parthea pushed a commit that referenced this pull request Sep 22, 2023
…eter (#9810)

* Makes `features` a keyword parameter to annotate_video

This reverts part of commit 853d6125082589fe3bf8a3f5b347507de73589da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: videointelligence Issues related to the Video Intelligence API API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants