New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add batch_create_session calls to session pools #9488
Merged
larkee
merged 7 commits into
googleapis:master
from
larkee:batch-create-sessions-manual
Oct 23, 2019
Merged
feat(spanner): add batch_create_session calls to session pools #9488
larkee
merged 7 commits into
googleapis:master
from
larkee:batch-create-sessions-manual
Oct 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 17, 2019
Build failure is due to a known flaky test. |
tseaver
approved these changes
Oct 22, 2019
crwilcox
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 22, 2019
crwilcox
approved these changes
Oct 22, 2019
Failure seems to be in an unrelated area.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
This human has signed the Contributor License Agreement.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, session pools are filled by creating single sessions. For large session pool sizes (>1000) this can be incredibly slow as it requires >1000 requests to be made to the server sequentially. Using batch_create_session calls to fill the pools will reduce the number of requests by a factor of 100 which will greatly reduce the start up time.
The BurstyPool does not use batch_create_session as it is designed to create sessions on an "as needed" basis rather than filling a queue.