Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): update storage endpoint from www.googleapis.com to storage.googleapis.com #9543

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

crwilcox
Copy link
Contributor

No description provided.

@crwilcox crwilcox requested a review from frankyn October 25, 2019 23:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
@crwilcox crwilcox added api: storage Issues related to the Cloud Storage API. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 25, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @crwilcox!

storage/google/cloud/storage/_http.py Show resolved Hide resolved
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@crwilcox
Copy link
Contributor Author

Cloud build is expected to fail as it is in progress yet. Merging.

@crwilcox crwilcox merged commit 764251d into master Oct 25, 2019
@crwilcox crwilcox deleted the update-storage-endpoint branch January 2, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants