Making datastore client inherit from base client #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Jul 1, 2015
This required lots of changes since the tests assume a client only optionally has a connection attached.
dhermes
force-pushed
the
client-parent-in-datastore
branch
from
793d7a8
to
dd93c80
Compare
|
@tseaver PTAL. I re-created this PR after you finished migrating |
|
Crap, I was just working on this one. :( |
|
What to do? Did you forget this PR existed? |
|
I think I prefer #1004: I was able to simplify some of the testing interactions w/ the mocked connection, and reduce coupling between 'test_client' and 'test_connection'. |
|
I didn't realize you were refreshing it. :( |
|
Closing. Bowing out to #1004 |
|
Sorry about that. I should've checked with you in Hangouts first. |
|
No worries. |
tseaver
added a commit
that referenced
this pull request
Jul 21, 2015
…ng_base Refresh #955: make datastore.Client derive from base client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This has #953 as a diffbase.
@tseaver This will likely conflict with #944, it's really more of an "ideas" PR.