Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(firestore): simplify 'Collection.add', avoid spurious API call #9634

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix(firestore): simplify 'Collection.add', avoid spurious API call #9634

merged 1 commit into from
Nov 7, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 7, 2019

/cc @samtstern

Closes #9629

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Nov 7, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2019
@tseaver tseaver merged commit 5621e9c into googleapis:master Nov 7, 2019
@tseaver tseaver deleted the 9629-firestore-tweak-collection-add branch November 7, 2019 20:03
@samtstern samtstern mentioned this pull request Nov 7, 2019
Closed
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@samtstern samtstern samtstern approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore: Incorrect implementation of collection.add()
4 participants
@tseaver @BenWhitehead @samtstern @googlebot