Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add timeout parameter to QueryJob.done() method #9875

Merged
merged 6 commits into from
Dec 19, 2019

Commits on Dec 17, 2019

  1. Configuration menu
    Copy the full SHA
    3801d2d View commit details
    Browse the repository at this point in the history
  2. Add tests for methods that got timeout param

    In addition, fix the timeout logic in QueryJob.done() - the timeouts
    are in different units (seconds vs. milliseconds)
    plamut committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    e75b30e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    28964f2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb95ca5 View commit details
    Browse the repository at this point in the history
  5. Update dependency pins

    The new timeout feature requires more recent versions of the API core
    and google auth dependencies.
    plamut committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    38f0f38 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Add safety margin on top of server-side timeout

    If the server-side processing timeout is used (the `timeout_ms` API
    parameter) as the total timeout, it should be slightly longer than
    the actual server-side timeout in order to not timeout the connection
    while there might still be chance that the server-side processing
    has actually completed.
    plamut committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    fe218df View commit details
    Browse the repository at this point in the history