Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pubsub): release 1.1.0 #9950

Merged
merged 2 commits into from
Dec 10, 2019
Merged

chore(pubsub): release 1.1.0 #9950

merged 2 commits into from
Dec 10, 2019

Conversation

pradn
Copy link
Contributor

@pradn pradn commented Dec 10, 2019 •
edited
Loading

Release a new version since there have been a few fixes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@pradn pradn changed the title pubsub(chore): release 1.0.3 chore(pubsub): release 1.0.3 Dec 10, 2019
plamut
plamut reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments about the grammar and the semantic version bump, although not super opinionated (feel free to disagree :) )

Edit: Oh, and the commit message should also be amended to follow the guideline (the check currently fails).

pubsub/setup.py Outdated Show resolved Hide resolved
pubsub/CHANGELOG.md Outdated Show resolved Hide resolved
pubsub/CHANGELOG.md Outdated Show resolved Hide resolved
pubsub/CHANGELOG.md Outdated Show resolved Hide resolved
@pradn
Fix commit message formatting. Change version from 1.0.3 to 1.1.0 bec…
85d75bf 
…ause the stop method was added to the publisher client.
@pradn pradn changed the title chore(pubsub): release 1.0.3 chore(pubsub): release 1.1.0 Dec 10, 2019
plamut
plamut approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut plamut merged commit 4d90932 into googleapis:master Dec 10, 2019
@pradn
Copy link
Contributor Author

pradn commented Dec 10, 2019 •
edited by plamut
Loading

Release is at https://github.com/googleapis/google-cloud-python/releases/tag/pubsub-1.1.0

@plamut
Copy link
Contributor

plamut commented Dec 10, 2019 •
edited
Loading

@pradn I manually changed the tag and release title to 1.1.0, please check if a manual run is needed to publish the release to PyPI (the bot might be tempted to upload the 1.0.3 tag).

Both tags point to the same commit, though.

@pradn
Copy link
Contributor Author

pradn commented Dec 10, 2019

Okay, I should have just made a new branch/PR with 1.0.1 to make it simple.

I deleted the 1.0.3 tag in the this repo. The 1.1.0 tag looks good. I added the "autorelease:tagged" flag back on to continue the release to PyPi.

Hopefully everything works now.

@plamut
Copy link
Contributor

plamut commented Dec 11, 2019

It appears the bot will have to be run manually, the similar thing happened when releasing API Core recently.

(cc: @busunkim96 )

@busunkim96
Copy link
Contributor

Released to pypi: https://pypi.org/project/google-cloud-pubsub/1.1.0

@plamut plamut added the api: pubsub Issues related to the Pub/Sub API. label Jan 21, 2020
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pradn @plamut @busunkim96 @googlebot