fix(automl): fix TablesClient.predict for array and struct #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
helinwang
force-pushed
the
prediction_fix
branch
2 times, most recently
from
edb9a2a
to
f58f6b1
Compare
helinwang
changed the title
helinwang
force-pushed
the
prediction_fix
branch
from
f58f6b1
to
f4604f5
Compare
The Predict request payload is proto. Previously Python dict is automatically converted to proto. However, the conversion failed for google.protobuf.ListValue and google.protobuf.Struct. Changing the structure of the Python dict might fix the problem. However, this PR fixes the problem by generating the proto message directly. So there is no auto conversion step. FIXES googleapis#9887
helinwang
force-pushed
the
prediction_fix
branch
from
f4604f5
to
66302e5
Compare
sirtorry
approved these changes
Dec 18, 2019
|
Friendly ping @busunkim96 |
busunkim96
suggested changes
Jan 27, 2020
protobuf is already a transitive dependency (see google-api-core's setup.py)
busunkim96
approved these changes
Jan 27, 2020
This was referenced Jan 29, 2020
Merged
Merged
This was referenced Jan 29, 2020
Merged
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* fix(automl): fix TablesClient.predict for list and struct The Predict request payload is proto. Previously Python dict is automatically converted to proto. However, the conversion failed for google.protobuf.ListValue and google.protobuf.Struct. Changing the structure of the Python dict might fix the problem. However, this PR fixes the problem by generating the proto message directly. So there is no auto conversion step. FIXES #9887 * Address comment: remove protobuf dependency requirement. protobuf is already a transitive dependency (see google-api-core's setup.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Predict request payload is proto. Previously Python dict is
automatically converted to proto. However, the conversion failed for
list item and dict item. Changing the structure of the Python dict might
fix the problem. However, this PR fixes the problem by generating the
proto message directly. So there is no auto conversion step.
FIXES #9887