Skip to content

Commit

Permalink
test(spanner): fix tests to avoid repeated updates to stubbed method …
Browse files Browse the repository at this point in the history
…calls. (#4788)

* Fix tests to avoid repeated updates to stubbed method calls.
  • Loading branch information
hengfengli committed Feb 10, 2020
1 parent c5a6238 commit b8156b5
Show file tree
Hide file tree
Showing 22 changed files with 214 additions and 230 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Expand Up @@ -106,9 +106,9 @@
it "resumes broken response streams" do
mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, RaiseableEnumerator.new(results_enum1), [session_grpc.name, "SELECT * FROM users", transaction: nil, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
mock.expect :execute_streaming_sql, RaiseableEnumerator.new(results_enum2), [session_grpc.name, "SELECT * FROM users", transaction: nil, params: nil, param_types: nil, resume_token: "abc123", partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql RaiseableEnumerator.new(results_enum1), session_grpc.name, "SELECT * FROM users", options: default_options
expect_execute_streaming_sql RaiseableEnumerator.new(results_enum2), session_grpc.name, "SELECT * FROM users", resume_token: "abc123", options: default_options

results = client.execute_query "SELECT * FROM users"

Expand Down
Expand Up @@ -71,8 +71,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { strong: true }

Expand All @@ -94,8 +94,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { timestamp: time_obj }

Expand All @@ -117,8 +117,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { read_timestamp: time_obj }

Expand All @@ -140,8 +140,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { staleness: 120 }

Expand All @@ -163,8 +163,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { exact_staleness: 120 }

Expand All @@ -186,8 +186,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { bounded_timestamp: time_obj }

Expand All @@ -209,8 +209,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { min_read_timestamp: time_obj }

Expand All @@ -232,8 +232,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { bounded_staleness: 120 }

Expand All @@ -255,8 +255,8 @@

mock = Minitest::Mock.new
mock.expect :create_session, session_grpc, [database_path(instance_id, database_id), session: nil, options: default_options]
mock.expect :execute_streaming_sql, results_enum, [session_grpc.name, "SELECT * FROM users", transaction: transaction, params: nil, param_types: nil, resume_token: nil, partition_token: nil, seqno: nil, options: default_options]
spanner.service.mocked_service = mock
expect_execute_streaming_sql results_enum, session_grpc.name, "SELECT * FROM users", transaction: transaction, options: default_options

results = client.execute_query "SELECT * FROM users", single_use: { max_staleness: 120 }

Expand Down

0 comments on commit b8156b5

Please sign in to comment.