Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to change concurrent-ruby version in gemspec #2890

Closed
danielmbarlow opened this issue Feb 7, 2019 · 2 comments · Fixed by #2892
Closed

Need to change concurrent-ruby version in gemspec #2890

danielmbarlow opened this issue Feb 7, 2019 · 2 comments · Fixed by #2892
Assignees
Labels
api: clouddebugger Issues related to the Cloud Debugger API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: logging Issues related to the Cloud Logging API.

Comments

@danielmbarlow
Copy link

danielmbarlow commented Feb 7, 2019

Environment details

  • OS: linux
  • Ruby version: 2.5
  • Gem name and version: 0.15.2 + 0.15.3
  • Rails 5.1.4

Steps to reproduce

Code example

Create test.rb containing:

require "google/cloud/error_reporting"

begin
  fail "Raise an exception for Error Reporting."
rescue => exception
  Google::Cloud::ErrorReporting.report exception
end

Run bin/rails r test.rb

Result:

uninitialized constant Concurrent::Promises (NameError)

Full backtrace

from ***/app/vendor/bundle/ruby/2.5.0/gems/google-cloud-error_reporting-0.31.0/lib/google/cloud/error_reporting.rb:230:in `report'
***/app/vendor/bundle/ruby/2.5.0/gems/google-cloud-error_reporting-0.31.0/lib/google/cloud/error_reporting/async_error_reporter.rb:94:in `report': uninitialized constant Concurrent::Promises (NameError)

Cause:
concurrent-ruby doesn't contain Concurrent::Promises:
https://github.com/ruby-concurrency/concurrent-ruby/tree/v1.0.5/lib/concurrent

v1.1.0 does:
https://github.com/ruby-concurrency/concurrent-ruby/blob/v1.1.0/lib/concurrent/promises.rb

gemspec contains: gem.add_dependency "concurrent-ruby", "~> 1.0"

@blowmage
Copy link
Contributor

blowmage commented Feb 7, 2019

Thanks for opening this issue, we will get the dependency updated ASAP.

@blowmage blowmage self-assigned this Feb 7, 2019
@blowmage blowmage added api: logging Issues related to the Cloud Logging API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: clouddebugger Issues related to the Cloud Debugger API. labels Feb 7, 2019
blowmage added a commit to blowmage/google-cloud-ruby that referenced this issue Feb 7, 2019
Update dependency to reflect the features used in the gem.

[fixes googleapis#2890]
blowmage added a commit that referenced this issue Feb 7, 2019
Update dependency to reflect the features used in the gem.

[pr #2892]
[fixes #2890]
@jeromedalbert
Copy link

jeromedalbert commented Jan 16, 2020

I had a similar issue where I would get uninitialized constant Concurrent::Promises (NameError) errors, even though I was using the latest stackdriver and google-cloud-logging gems.

The problem was that an unrelated gem in my Gemfile was requiring an old 1.0.x version of concurrent-ruby when at least 1.1 is needed.

To fix this, I updated my unrelated gem, which allowed concurrent-ruby to bump to 1.1.5 and solved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouddebugger Issues related to the Cloud Debugger API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: logging Issues related to the Cloud Logging API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants