Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate build failure #4280

Closed
blowmage opened this issue Oct 25, 2019 · 4 comments · Fixed by #4820
Closed

Investigate build failure #4280

blowmage opened this issue Oct 25, 2019 · 4 comments · Fixed by #4820
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.

Comments

@blowmage
Copy link
Contributor

Seen this in two different build failures:

  1) Error:
Google::Cloud::PubSub::Topic::publish_async::ordered_messages::mock_pubsub#test_0002_publishes messages with ordering_key and callback:
NoMethodError: undefined method `lock' for nil:NilClass
    /root/.rbenv/versions/2.5.7/lib/ruby/2.5.0/monitor.rb:192:in `mon_enter'
    /root/.rbenv/versions/2.5.7/lib/ruby/2.5.0/monitor.rb:233:in `block in mon_synchronize'
    /root/.rbenv/versions/2.5.7/lib/ruby/2.5.0/monitor.rb:233:in `handle_interrupt'
    /root/.rbenv/versions/2.5.7/lib/ruby/2.5.0/monitor.rb:233:in `mon_synchronize'
    /tmpfs/src/github/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb:279:in `run_background'
    /tmpfs/src/github/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb:87:in `block in initialize'
@blowmage blowmage added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Oct 25, 2019
@blowmage blowmage self-assigned this Oct 25, 2019
@quartzmo
Copy link
Member

This is the error line for the links above (more recent commits have shifted the code).

@quartzmo
Copy link
Member

Should the initialization of @cond be moved higher in the initializer? Above this line?

@blowmage
Copy link
Contributor Author

Should the initialization of @cond be moved higher in the initializer? Above this line?

Ugh, probably... Good, catch.

@quartzmo quartzmo assigned quartzmo and unassigned blowmage Feb 13, 2020
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants