Create stackdriver-core gem with code to manage trace context #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
hxiong388
reviewed
Dec 6, 2016
| { | ||
| "title": "Stackdriver Core", | ||
| "type": "stackdriver/core" | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I went through and updated the jsondocs and related configs (thanks @hxiong388 for the help). PTAL. |
blowmage
approved these changes
Dec 13, 2016
hxiong388
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a stackdriver-core gem for shared code among the various Stackdriver libraries.
Initially, this gem implements TraceContext tracking (currently partially implemented in google-cloud-logging). I want to centralize it because the Trace instrumentation work requires that multiple libraries (currently google-cloud-trace and google-cloud-logging, but likely to include the other Stackdriver gems in the future) be able to cooperate in managing this context data.
After the stackdriver-core gem is released, google-cloud-logging will be modified to use this central code rather than its own partial implementation.
Note: a previous proposal added this functionality to google-cloud-core (see #1098). However, @blowmage and @dazuma decided offline to split off a separate gem instead.