Upgrade yard-doctest dependency

Gemfile

@@ -11,7 +11,7 @@ gem "rubocop", "~> 0.50.0"
 gem "simplecov", "~> 0.9"
 gem "coveralls", "~> 0.7"
 gem "yard", "~> 0.9"
-gem "yard-doctest", "<= 0.1.8"
+gem "yard-doctest", "~> 0.1.13"
 gem "gems", "~> 0.8"
 gem "actionpack", "~> 4.0"
 gem "railties", "~> 4.0"

gcloud/Rakefile

@@ -61,13 +61,17 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING gcloud"
   header "gcloud rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "gcloud yard", "*"
+  sh "bundle exec rake yard"
   header "gcloud doctest", "*"
   sh "bundle exec rake doctest"
   header "gcloud test", "*"

gcloud/gcloud.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 
   gem.post_install_message = "gcloud is now google-cloud, please change the gem name in your dependencies"
 end

google-cloud-bigquery/Rakefile

@@ -133,8 +133,8 @@ namespace :benchmark do
 end
 
 desc "Run yard-doctest example tests."
-task doctest: :yard do
-  sh "bundle exec yard doctest"
+task :doctest do
+  sh "bundle exec yard config load_plugins true && bundle exec yard doctest"
 end
 
 desc "Start an interactive shell."
@@ -154,13 +154,17 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-bigquery"
   header "google-cloud-bigquery rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-bigquery yard", "*"
+  sh "bundle exec rake yard"
   header "google-cloud-bigquery doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-bigquery test", "*"

google-cloud-bigquery/google-cloud-bigquery.gemspec

@@ -32,5 +32,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-bigquery/support/doctest_helper.rb

@@ -163,9 +163,6 @@ def mock_storage
   # Google::Cloud::Bigquery::Dataset#access@Manage the access rules by passing a block:
   doctest.before "Google::Cloud::Bigquery::Dataset#access" do
     mock_bigquery do |mock|
-      def other_dataset_view_object
-        "foo"
-      end
       mock.expect :insert_dataset, dataset_full_gapi, ["my-project", Google::Apis::BigqueryV2::Dataset]
       mock.expect :get_dataset, dataset_full_gapi, ["my-project", "my_dataset"]
       mock.expect :patch_dataset, dataset_full_gapi, ["my-project", "my_dataset", Google::Apis::BigqueryV2::Dataset, Hash]
@@ -361,9 +358,6 @@ def other_dataset_view_object
 
   doctest.before "Google::Cloud::Bigquery::Dataset::Access" do
     mock_bigquery do |mock|
-      def other_dataset_view_object
-        "foo"
-      end
       mock.expect :insert_dataset, dataset_full_gapi, ["my-project", Google::Apis::BigqueryV2::Dataset]
       mock.expect :get_dataset, dataset_full_gapi, ["my-project", "my_dataset"]
       mock.expect :get_dataset, dataset_full_gapi, ["my-project", "my_other_dataset"] # for view methods
@@ -1286,3 +1280,7 @@ def list_projects_gapi count = 2, token = nil
 def time_millis
   (Time.now.to_f * 1000).floor.to_s
 end
+
+def other_dataset_view_object
+  "foo"
+end

google-cloud-bigtable/Rakefile

@@ -146,7 +146,9 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  # y.options << "--fail-on-warning"
+end
 
 desc "Run yard-doctest example tests."
 task :doctest do
@@ -158,6 +160,9 @@ task :ci do
   header "BUILDING google-cloud-bigtable"
   header "google-cloud-bigtable rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-bigtable yard", "*"
+  header "bigtable yard still had warnings", "!"
+  sh "bundle exec rake yard"
   header "google-cloud-bigtable doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-bigtable test", "*"

google-cloud-bigtable/google-cloud-bigtable.gemspec

@@ -32,5 +32,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-core/Rakefile

@@ -60,14 +60,18 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-core"
   header "google-cloud-core rubocop", "*"
   sh "bundle exec rake rubocop"
   header "google-cloud-core doctest", "*"
+  sh "bundle exec rake yard"
+  header "google-cloud-core yard", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-core test", "*"
   sh "bundle exec rake test"

google-cloud-core/google-cloud-core.gemspec

@@ -30,5 +30,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-datastore/Rakefile

@@ -80,8 +80,8 @@ namespace :acceptance do
 end
 
 desc "Run yard-doctest example tests."
-task doctest: :yard do
-  sh "bundle exec yard doctest"
+task :doctest do
+  sh "bundle exec yard config load_plugins true && bundle exec yard doctest"
 end
 
 desc "Start an interactive shell."
@@ -101,13 +101,18 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  # y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-datastore"
   header "google-cloud-datastore rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-datastore yard", "*"
+  header "datastore yard still had warnings", "!"
+  sh "bundle exec rake yard"
   header "google-cloud-datastore doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-datastore test", "*"

google-cloud-datastore/google-cloud-datastore.gemspec

@@ -31,5 +31,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-debugger/Rakefile

@@ -30,7 +30,7 @@ task :recompile do
 end
 
 desc "Run tests."
-task :test => :compile do
+task test: :compile do
   $LOAD_PATH.unshift "lib", "test"
   Dir.glob("test/**/*_test.rb").each { |file| require_relative file }
 end
@@ -130,8 +130,8 @@ namespace :integration do
 end
 
 desc "Run yard-doctest example tests."
-task doctest: :yard do
-  sh "bundle exec yard doctest"
+task :doctest do
+  sh "bundle exec yard config load_plugins true && bundle exec yard doctest"
 end
 
 desc "Start an interactive shell."
@@ -151,13 +151,17 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
-task :ci do
+task ci: :compile do
   header "BUILDING google-cloud-debugger"
   header "google-cloud-debugger rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-debugger yard", "*"
+  sh "bundle exec rake yard"
   header "google-cloud-debugger doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-debugger test", "*"

google-cloud-dns/Rakefile

@@ -108,8 +108,8 @@ namespace :acceptance do
 end
 
 desc "Run yard-doctest example tests."
-task doctest: :yard do
-  sh "bundle exec yard doctest"
+task :doctest do
+  sh "bundle exec yard config load_plugins true && bundle exec yard doctest"
 end
 
 desc "Start an interactive shell."
@@ -129,13 +129,17 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-dns"
   header "google-cloud-dns rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-dns yard", "*"
+  sh "bundle exec rake yard"
   header "google-cloud-dns doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-dns test", "*"

google-cloud-dns/google-cloud-dns.gemspec

@@ -32,5 +32,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-env/Rakefile

@@ -59,13 +59,17 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-env"
   header "google-cloud-env rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-env yard", "*"
+  sh "bundle exec rake yard"
   header "google-cloud-env doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-env test", "*"

google-cloud-env/google-cloud-env.gemspec

@@ -29,5 +29,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-error_reporting/Rakefile

@@ -84,8 +84,8 @@ namespace :acceptance do
 end
 
 desc "Run yard-doctest example tests."
-task doctest: :yard do
-  sh "bundle exec yard doctest"
+task :doctest do
+  sh "bundle exec yard config load_plugins true && bundle exec yard doctest"
 end
 
 namespace :integration do
@@ -131,13 +131,18 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  # y.options << "--fail-on-warning"
+end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-error_reporting"
   header "google-cloud-error_reporting rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-error_reporting yard", "*"
+  header "error_reporting yard still had warnings", "!"
+  sh "bundle exec rake yard"
   header "google-cloud-error_reporting doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-error_reporting test", "*"

google-cloud-error_reporting/google-cloud-error_reporting.gemspec

@@ -34,5 +34,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rack", ">= 0.1"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end

google-cloud-firestore/Rakefile

@@ -154,18 +154,23 @@ end
 
 require "yard"
 require "yard/rake/yardoc_task"
-YARD::Rake::YardocTask.new
+YARD::Rake::YardocTask.new do |y|
+  # y.options << "--fail-on-warning"
+end
 
 desc "Run yard-doctest example tests."
-task doctest: :yard do
-  sh "bundle exec yard doctest"
+task :doctest do
+  sh "bundle exec yard config load_plugins true && bundle exec yard doctest"
 end
 
 desc "Run the CI build"
 task :ci do
   header "BUILDING google-cloud-firestore"
   header "google-cloud-firestore rubocop", "*"
   sh "bundle exec rake rubocop"
+  header "google-cloud-firestore yard", "*"
+  header "firestore yard still had warnings", "!"
+  sh "bundle exec rake yard"
   header "google-cloud-firestore doctest", "*"
   sh "bundle exec rake doctest"
   header "google-cloud-firestore test", "*"

google-cloud-firestore/google-cloud-firestore.gemspec

@@ -33,5 +33,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rubocop", "~> 0.50.0"
   gem.add_development_dependency "simplecov", "~> 0.9"
   gem.add_development_dependency "yard", "~> 0.9"
-  gem.add_development_dependency "yard-doctest", "<= 0.1.8"
+  gem.add_development_dependency "yard-doctest", "~> 0.1.13"
 end