Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): Update minitest to 5.14 #5654

Merged
merged 6 commits into from Apr 22, 2020

Conversation

quartzmo
Copy link
Member

Use rubocop-minitest gem and bundle exec rubocop --only Minitest/GlobalExpectations -a to autocorrect minitest warnings for Ruby 2.7.

refs: #4110
refs: #4116

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2020
@quartzmo quartzmo requested a review from a team April 22, 2020 19:22
@quartzmo quartzmo self-assigned this Apr 22, 2020
@quartzmo quartzmo added the api: spanner Issues related to the Spanner API. label Apr 22, 2020
@quartzmo
Copy link
Member Author

I've been trying to get a successful rake acceptance run for this gem, but it has been hanging:

% b rake acceptance
Run options: --seed 35659

# Running:

.......................................................................................................................................................................Error while cleaning up instances and databases after spanner tests.

4:Deadline Exceeded


@dazuma
Copy link
Member

dazuma commented Apr 22, 2020

@quartzmo Does it also hang without the minitest conversion?

@quartzmo
Copy link
Member Author

Does it also hang without the minitest conversion?

Yes, I ran once before making changes and that run did not complete either.

@quartzmo
Copy link
Member Author

quartzmo commented Apr 22, 2020

I checked the log for the most recent linux nightly build on Kokoro (8 hours ago), it succeeded there. So I will try again now locally using master.

***************************************
*** google-cloud-spanner acceptance ***
***************************************

Run options: --seed 2124

# Running:

..........................................................................................................................................................................................................................................................

Finished in 903.844925s, 0.2766 runs/s, 4.2076 assertions/s.

@quartzmo
Copy link
Member Author

It looks like the problem is exceeding the maximum number of pending backups:

Google::Cloud::FailedPreconditionError: 9:Cannot create backup (projects/bustling-kayak-91516/instances/google-cloud-ruby-tests/backups/gcruby-200422-9cab42ca-cancel) for database (projects/bustling-kayak-91516/instances/google-cloud-ruby-tests/databases/gcruby-200422-9cab42ca) because the maximum number of pending backups (1) for the database has been reached. Please retry the operation once the pending backups complete.

Trying a test run with a different project.

@dazuma
Copy link
Member

dazuma commented Apr 22, 2020

Hmm. That sounds like a test that's going to flake on us a lot, any time multiple tests overlap or tests otherwise happen too quickly. A database backup seems like a heavyweight operation that shouldn't happen as often as these test will run. I think we should consider disabling it (open a separate issue to do so.)

Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM.

@quartzmo
Copy link
Member Author

I think we should consider disabling it (open a separate issue to do so.)

I think you're right. I'm currently running the acceptance tests locally using the CI project. They appear to have hung again. When it finally exits I'll post the results here, and if it's the backups again, open the new issue.

@quartzmo quartzmo merged commit 6dcef05 into googleapis:master Apr 22, 2020
@quartzmo quartzmo deleted the spanner-minitest-update branch April 22, 2020 22:22
@quartzmo
Copy link
Member Author

quartzmo commented Apr 22, 2020

Confirmed: Same errors with the other project:

Spanner Database Backup::spanner#test_0001_creates, get, updates, restore and delete a database backup:
Google::Cloud::FailedPreconditionError: 9:Cannot create backup (projects/helical-zone-771/instances/google-cloud-ruby-tests/backups/gcruby-200422-503cdf89-crud) for database (projects/helical-zone-771/instances/google-cloud-ruby-tests/databases/gcruby-200422-503cdf89) because the maximum number of pending backups (1) for the database has been reached. Please retry the operation once the pending backups complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants