New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(spanner): Update minitest to 5.14 #5654
Conversation
…e test helper.rb since it now has no effect, see ruby-concurrency/concurrent-ruby#841
I've been trying to get a successful
|
@quartzmo Does it also hang without the minitest conversion? |
Yes, I ran once before making changes and that run did not complete either. |
I checked the log for the most recent linux nightly build on Kokoro (8 hours ago), it succeeded there. So I will try again now locally using
|
It looks like the problem is exceeding the maximum number of pending backups:
Trying a test run with a different project. |
Hmm. That sounds like a test that's going to flake on us a lot, any time multiple tests overlap or tests otherwise happen too quickly. A database backup seems like a heavyweight operation that shouldn't happen as often as these test will run. I think we should consider disabling it (open a separate issue to do so.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM.
I think you're right. I'm currently running the acceptance tests locally using the CI project. They appear to have hung again. When it finally exits I'll post the results here, and if it's the backups again, open the new issue. |
Confirmed: Same errors with the other project:
|
Use
rubocop-minitest
gem andbundle exec rubocop --only Minitest/GlobalExpectations -a
to autocorrect minitest warnings for Ruby 2.7.refs: #4110
refs: #4116