Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): Update documentation of SignedUrlUnavailable #6924

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

quartzmo
Copy link
Member

closes: #6268

@quartzmo quartzmo requested a review from a team as a code owner June 26, 2020 15:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@quartzmo quartzmo self-assigned this Jun 26, 2020
@quartzmo quartzmo added api: storage Issues related to the Cloud Storage API. type: docs Improvement to the documentation for an API. labels Jun 26, 2020
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Please address the comment before merging.

# @raise [SignedUrlUnavailable] If the service account credentials
# are missing. Service account credentials are acquired by following the
# steps in [Service Account Authentication](
# https://cloud.google.com/iam/docs/service-accounts).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some markdown parsers don't like the whitespace inside the URL parens. If you really need to line break, do something like:

[Service Account
Authentication](https://cloud.google.com/iam/docs/service_accounts)

Same for additional instances below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Thanks for catching.

@quartzmo quartzmo merged commit f30f264 into googleapis:master Jun 29, 2020
@quartzmo quartzmo deleted the storage-signed-url-unavailable branch June 29, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCS - signed URLs (local development)
3 participants