fix(storage): Fix encoding of space characters in file names in signed_url v4 #7860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
/cc @chvreddy |
frankyn
approved these changes
Oct 2, 2020
|
@chvreddy This fix was released today in google-cloud-storage v1.29.1, thank you! |
|
@quartzmo Thank you very much! |
|
@chvreddy Very happy that you brought this to our attention! Please reopen your original issue if the fix doesn't work for you or isn't complete. And always feel free to open issues for anything that needs to be improved. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acceptance test coverage for this change passes for me locally. Updates to the conformance tests to provide unit test coverage for this change are still pending.
closes: #7835