Language setup #841
Merged
Language setup #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call annotation and get response object modeled out. Model Document to hold text vs. html, and content vs. GSC url.
blowmage
added
the
api: language
googlebot
added
the
cla: yes
|
Coverage decreased (-1.4%) to 94.353% when pulling d82515d877609c3b80162fa853f92d05b63df610 on blowmage:language-setup into 598f85f on GoogleCloudPlatform:master. |
Also add some unit test coverage for Entity and Entities.
blowmage
force-pushed
the
language-setup
branch
from
d82515d
to
1251517
Compare
2 similar comments
| annotation.tokens.must_be :empty? | ||
| end | ||
|
|
||
| it "runs only the sentiment feature" do |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I'm really happy with this new approach to test-driving the development against a new service. The acceptance test coverage is just awesome, and the unit tests that follow are based on empirical fact, not speculation. This is the way to do it imo. |
|
Ugh, I would love to merge this, but Job #1403 seems stalled. I'll wait a bit longer. |
Allow Document to know if it contains content or a URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand up the Natural Language service implementation. I decided to drive the development against the live service using acceptance tests, hence the lack of mocked out unit tests. Unit tests will be added in a later PR, but for now it would be good to get this implementation accepted so we can start moving on other concerns like documentation. (There is some documentation, but it is no where near final.)
The service is most similar to Vision. There is a main
#annotationmethod that takes content arguments, and a Document class that models the content and can also call an#annotationmethod.