Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify header comments slightly #38

Closed
grant opened this issue Nov 12, 2020 · 0 comments · Fixed by #39
Closed

Modify header comments slightly #38

grant opened this issue Nov 12, 2020 · 0 comments · Fixed by #39
Assignees
@grant
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API.

Comments

@grant
Copy link
Contributor

grant commented Nov 12, 2020

A release failed because the license header comment is slightly off:

[ERROR] /tmpfs/src/github/google-cloudevents-java/src/main/java/com/google/events/firebase/analytics/v1/AppInfo.java:1: Line does not match expected header line of '^/\*$'. [RegexpHeader]

Solution

Make sure Java headers only start with /*, not /**.

Example good header: https://github.com/googleapis/google-api-java-client/blob/master/google-api-client/src/main/java/com/google/api/client/googleapis/GoogleUtils.java
@grant grant self-assigned this Nov 12, 2020
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-java API. label Nov 12, 2020
This was referenced Nov 12, 2020
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/google-cloudevents that referenced this issue Nov 12, 2020
@grant
fix: update java headers and ruby (#107)
721f17b 
Fixes Java headers and Ruby file names.

See googleapis/google-cloudevents-java#38
@grant grant closed this as completed in #39 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use java specific headers googleapis/google-cloudevents-java
1 participant
@grant