Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 7 test #1713

Closed
suztomo opened this issue Aug 25, 2022 · 4 comments · Fixed by #1847
Closed

Java 7 test #1713

suztomo opened this issue Aug 25, 2022 · 4 comments · Fixed by #1847
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@suztomo
Copy link
Member

suztomo commented Aug 25, 2022

This change f0c0488 seems to have removed Java 7 tests.
@suztomo suztomo mentioned this issue Aug 25, 2022
Closed
@alicejli
Copy link
Contributor

alicejli commented Sep 2, 2022

@suztomo I thought Java 7 was no longer officially supported after July this year, per https://cloud.google.com/java/docs/supported-java-versions?

@lqiu96
Copy link

lqiu96 commented Sep 13, 2022

@suztomo Bumping thread.

Agree with @alicejli. Do we need to keep Java 7 support for this library?

image

@lqiu96 lqiu96 added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Sep 13, 2022
@suztomo
Copy link
Member Author

suztomo commented Sep 13, 2022 •
edited

For Android compatibility of Apiary, this repository targets Java 7 https://github.com/googleapis/google-http-java-client/blob/main/pom.xml#L282

https://screenshot.googleplex.com/3rQ276zDdyExzcP.png

@lqiu96
Copy link

lqiu96 commented Sep 13, 2022

Ah, makes sense. I'll revisit #1714 then

@suztomo suztomo mentioned this issue May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Milestone
No milestone
3 participants
@suztomo @lqiu96 @alicejli