Skip to content

Commit

Permalink
chore: enable gapicv2 for firestore/admin/v1 API
Browse files Browse the repository at this point in the history
Committer: @miraleung

There are the following breaking changes due to the collection_id discrepancy between [1] and [2]

1. https://github.com/googleapis/googleapis/blob/6f8350c0df231d7e742fa10dbf929f33047715c9/google/firestore/admin/v1/firestore_gapic.yaml#L24-L29
2. https://github.com/googleapis/googleapis/blob/6f8350c0df231d7e742fa10dbf929f33047715c9/google/firestore/admin/v1/field.proto#L39
```
com.google.firestore.admin.v1.FieldName: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.FieldName: Method 'public java.lang.String getFieldId()' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public java.lang.String getFieldId()' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public com.google.firestore.admin.v1.FieldName$Builder setCollectionId(java.lang.String)' has been removed
com.google.firestore.admin.v1.FieldName$Builder: Method 'public com.google.firestore.admin.v1.FieldName$Builder setFieldId(java.lang.String)' has been removed
com.google.firestore.admin.v1.IndexName: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.IndexName: Method 'public java.lang.String getIndexId()' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public java.lang.String getCollectionId()' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public java.lang.String getIndexId()' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public com.google.firestore.admin.v1.IndexName$Builder setCollectionId(java.lang.String)' has been removed
com.google.firestore.admin.v1.IndexName$Builder: Method 'public com.google.firestore.admin.v1.IndexName$Builder setIndexId(java.lang.String)' has been removed
```

PiperOrigin-RevId: 305561114
  • Loading branch information
Google APIs authored and Copybara-Service committed Apr 8, 2020
1 parent 6f8350c commit 0d69cdd
Show file tree
Hide file tree
Showing 2 changed files with 200 additions and 166 deletions.
199 changes: 199 additions & 0 deletions google/firestore/admin/v1/firestore_gapic.legacy.yaml
@@ -0,0 +1,199 @@
type: com.google.api.codegen.ConfigProto
config_schema_version: 1.0.0
language_settings:
java:
package_name: com.google.cloud.firestore.v1
python:
package_name: google.cloud.firestore_admin_v1.gapic
go:
package_name: cloud.google.com/go/firestore/apiv1/admin
csharp:
package_name: Google.Cloud.Firestore.Admin.V1
ruby:
package_name: Google::Cloud::Firestore::Admin::V1
php:
package_name: Google\Cloud\Firestore\Admin\V1
nodejs:
package_name: firestore.v1
domain_layer_location: google-cloud
interfaces:
- name: google.firestore.admin.v1.FirestoreAdmin
collections:
- name_pattern: projects/{project}/databases/{database}
entity_name: database
- name_pattern: projects/{project}/databases/{database}/collectionGroups/{collection_id}
entity_name: parent
- name_pattern: projects/{project}/databases/{database}/collectionGroups/{collection_id}/indexes/{index_id}
entity_name: index
- name_pattern: projects/{project}/databases/{database}/collectionGroups/{collection_id}/fields/{field_id}
entity_name: field
retry_codes_def:
- name: idempotent
retry_codes:
- UNAVAILABLE
- INTERNAL
- DEADLINE_EXCEEDED
- name: non_idempotent
retry_codes: []
retry_params_def:
- name: default
initial_retry_delay_millis: 100
retry_delay_multiplier: 1.3
max_retry_delay_millis: 60000
initial_rpc_timeout_millis: 60000
rpc_timeout_multiplier: 1
max_rpc_timeout_millis: 60000
total_timeout_millis: 600000
methods:
- name: CreateIndex
flattening:
groups:
- parameters:
- parent
- index
required_fields:
- parent
- index
retry_codes_name: non_idempotent
retry_params_name: default
field_name_patterns:
parent: parent
timeout_millis: 60000
- name: ListIndexes
flattening:
groups:
- parameters:
- parent
required_fields:
- parent
page_streaming:
request:
page_size_field: page_size
token_field: page_token
response:
token_field: next_page_token
resources_field: indexes
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
parent: parent
timeout_millis: 60000
- name: GetIndex
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
name: index
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: DeleteIndex
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
name: index
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: ImportDocuments
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: non_idempotent
retry_params_name: default
field_name_patterns:
name: database
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: ExportDocuments
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: non_idempotent
retry_params_name: default
field_name_patterns:
name: database
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: GetField
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
name: field
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: ListFields
flattening:
groups:
- parameters:
- parent
required_fields:
- parent
page_streaming:
request:
page_size_field: page_size
token_field: page_token
response:
token_field: next_page_token
resources_field: fields
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
parent: parent
timeout_millis: 60000
- name: UpdateField
flattening:
groups:
- parameters:
- field
required_fields:
- field
retry_codes_name: non_idempotent
retry_params_name: default
timeout_millis: 60000
resource_name_generation:
- message_name: CreateIndexRequest
field_entity_map:
parent: parent
- message_name: GetIndexRequest
field_entity_map:
name: index
- message_name: DeleteIndexRequest
field_entity_map:
name: index
- message_name: ImportDocumentsRequest
field_entity_map:
name: database
- message_name: ExportDocumentsRequest
field_entity_map:
name: database
- message_name: GetFieldRequest
field_entity_map:
name: field
- message_name: ListFieldsRequest
field_entity_map:
parent: parent
- message_name: ListIndexesRequest
field_entity_map:
parent: parent
167 changes: 1 addition & 166 deletions google/firestore/admin/v1/firestore_gapic.yaml
@@ -1,5 +1,5 @@
type: com.google.api.codegen.ConfigProto
config_schema_version: 1.0.0
config_schema_version: 2.0.0
language_settings:
java:
package_name: com.google.cloud.firestore.v1
Expand All @@ -18,23 +18,6 @@ language_settings:
domain_layer_location: google-cloud
interfaces:
- name: google.firestore.admin.v1.FirestoreAdmin
collections:
- name_pattern: projects/{project}/databases/{database}
entity_name: database
- name_pattern: projects/{project}/databases/{database}/collectionGroups/{collection_id}
entity_name: parent
- name_pattern: projects/{project}/databases/{database}/collectionGroups/{collection_id}/indexes/{index_id}
entity_name: index
- name_pattern: projects/{project}/databases/{database}/collectionGroups/{collection_id}/fields/{field_id}
entity_name: field
retry_codes_def:
- name: idempotent
retry_codes:
- UNAVAILABLE
- INTERNAL
- DEADLINE_EXCEEDED
- name: non_idempotent
retry_codes: []
retry_params_def:
- name: default
initial_retry_delay_millis: 100
Expand All @@ -45,155 +28,7 @@ interfaces:
max_rpc_timeout_millis: 60000
total_timeout_millis: 600000
methods:
- name: CreateIndex
flattening:
groups:
- parameters:
- parent
- index
required_fields:
- parent
- index
retry_codes_name: non_idempotent
retry_params_name: default
field_name_patterns:
parent: parent
timeout_millis: 60000
- name: ListIndexes
flattening:
groups:
- parameters:
- parent
required_fields:
- parent
page_streaming:
request:
page_size_field: page_size
token_field: page_token
response:
token_field: next_page_token
resources_field: indexes
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
parent: parent
timeout_millis: 60000
- name: GetIndex
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
name: index
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: DeleteIndex
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
name: index
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: ImportDocuments
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: non_idempotent
retry_params_name: default
field_name_patterns:
name: database
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: ExportDocuments
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: non_idempotent
retry_params_name: default
field_name_patterns:
name: database
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: GetField
flattening:
groups:
- parameters:
- name
required_fields:
- name
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
name: field
timeout_millis: 60000
resource_name_treatment: STATIC_TYPES
- name: ListFields
flattening:
groups:
- parameters:
- parent
required_fields:
- parent
page_streaming:
request:
page_size_field: page_size
token_field: page_token
response:
token_field: next_page_token
resources_field: fields
retry_codes_name: idempotent
retry_params_name: default
field_name_patterns:
parent: parent
timeout_millis: 60000
- name: UpdateField
flattening:
groups:
- parameters:
- field
required_fields:
- field
retry_codes_name: non_idempotent
retry_params_name: default
timeout_millis: 60000
resource_name_generation:
- message_name: CreateIndexRequest
field_entity_map:
parent: parent
- message_name: GetIndexRequest
field_entity_map:
name: index
- message_name: DeleteIndexRequest
field_entity_map:
name: index
- message_name: ImportDocumentsRequest
field_entity_map:
name: database
- message_name: ExportDocumentsRequest
field_entity_map:
name: database
- message_name: GetFieldRequest
field_entity_map:
name: field
- message_name: ListFieldsRequest
field_entity_map:
parent: parent
- message_name: ListIndexesRequest
field_entity_map:
parent: parent

0 comments on commit 0d69cdd

Please sign in to comment.