Skip to content

Commit

Permalink
fix!: Updated resource patterns to comply with https://google.aip.dev…
Browse files Browse the repository at this point in the history
…/123#annotating-resource-types

PiperOrigin-RevId: 438230444
  • Loading branch information
Google APIs authored and Copybara-Service committed Mar 30, 2022
1 parent 510c51d commit 1821985
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
8 changes: 4 additions & 4 deletions google/cloud/certificatemanager/v1/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ py_gapic_library(
srcs = [":certificatemanager_proto"],
grpc_service_config = "certificatemanager_grpc_service_config.json",
opt_args = [
"warehouse-package-name=google-cloud-certificate-manager",
"python-gapic-namespace=google.cloud",
"python-gapic-name=certificate_manager",
"python-gapic-namespace=google.cloud",
"warehouse-package-name=google-cloud-certificate-manager",
],
)

Expand Down Expand Up @@ -279,10 +279,10 @@ ruby_cloud_gapic_library(
name = "certificatemanager_ruby_gapic",
srcs = [":certificatemanager_proto_with_info"],
extra_protoc_parameters = [
"ruby-cloud-gem-name=google-cloud-certificate_manager-v1",
"ruby-cloud-product-url=https://cloud.google.com/certificate-manager",
"ruby-cloud-api-id=certificatemanager.googleapis.com",
"ruby-cloud-api-shortname=certificatemanager",
"ruby-cloud-gem-name=google-cloud-certificate_manager-v1",
"ruby-cloud-product-url=https://cloud.google.com/certificate-manager",
],
grpc_service_config = "certificatemanager_grpc_service_config.json",
ruby_cloud_description = "Certificate Manager lets you acquire and manage Transport Layer Security (TLS) (SSL) certificates for use with classic external HTTP(S) load balancers in Google Cloud.",
Expand Down
8 changes: 5 additions & 3 deletions google/cloud/certificatemanager/v1/certificate_manager.proto
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ option php_namespace = "Google\\Cloud\\CertificateManager\\V1";
option ruby_package = "Google::Cloud::CertificateManager::V1";
option (google.api.resource_definition) = {
type: "compute.googleapis.com/TargetHttpsProxies"
pattern: "projects/{project}/locations/{location}/targetHttpsProxies/{targetHttpsProxy}"
pattern: "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}"
};
option (google.api.resource_definition) = {
type: "compute.googleapis.com/TargetSslProxies"
pattern: "projects/{project}/locations/{location}/targetSslProxies/{targetSslProxy}"
pattern: "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}"
};

// API Overview
Expand Down Expand Up @@ -877,7 +877,9 @@ message Certificate {
}

// Output only. The list of Subject Alternative Names of dnsName type defined in the
// certificate (see RFC 5280 4.2.1.6)
// certificate (see RFC 5280 4.2.1.6).
// Managed certificates that haven't been provisioned yet have this field
// populated with a value of the managed.domains field.
repeated string san_dnsnames = 6 [(google.api.field_behavior) = OUTPUT_ONLY];

// Output only. The PEM-encoded certificate chain.
Expand Down

0 comments on commit 1821985

Please sign in to comment.