Skip to content

Commit

Permalink
docs: updates DEP proto comments
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 609406502
  • Loading branch information
Google APIs authored and Copybara-Service committed Feb 22, 2024
1 parent ebe0794 commit 2f14a03
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 19 deletions.
1 change: 1 addition & 0 deletions google/cloud/networkservices/v1beta1/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ load(

csharp_proto_library(
name = "networkservices_csharp_proto",
extra_opts = [],
deps = [":networkservices_proto"],
)

Expand Down
40 changes: 21 additions & 19 deletions google/cloud/networkservices/v1beta1/dep.proto
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ service DepService {
}

// Load balancing schemes supported by the `LbTrafficExtension` resource and
// `LbRouteExtension` resource. The valid values are: `INTERNAL_MANAGED`,
// `LbRouteExtension` resource. The valid values are `INTERNAL_MANAGED` and
// `EXTERNAL_MANAGED`.
// For more information, refer to [Choosing a load
// balancer](https://cloud.google.com/load-balancing/docs/backend-service).
Expand All @@ -191,13 +191,13 @@ message ExtensionChain {
//
// For more information, see
// [CEL matcher language
// reference](https://cloud.google.com/service-extensions/docs/cel-matcher-language-reference).
// reference](/service-extensions/docs/cel-matcher-language-reference).
string cel_expression = 1 [(google.api.field_behavior) = REQUIRED];
}

// A single extension in the chain to execute for the matching request.
message Extension {
// Defines the part of the request or response for which this extension
// The part of the request or response for which this extension
// is called.
// The valid values are:
// `REQUEST_HEADERS`, `REQUEST_BODY`, `RESPONSE_HEADERS`, `RESPONSE_BODY`.
Expand Down Expand Up @@ -230,15 +230,15 @@ message ExtensionChain {
// last a letter or a number.
string name = 1 [(google.api.field_behavior) = REQUIRED];

// Required. The `:authority` header in the gRPC request sent from Envoy
// Optional. The `:authority` header in the gRPC request sent from Envoy
// to the extension service.
string authority = 2 [(google.api.field_behavior) = REQUIRED];
string authority = 2 [(google.api.field_behavior) = OPTIONAL];

// Required. The reference to the service that runs the extension.
//
// Currently only Callout extensions are supported here.
// Currently only callout extensions are supported here.
//
// To configure a Callout extension, `service` must be a fully-qualified
// To configure a callout extension, `service` must be a fully-qualified
// reference
// to a [backend
// service](https://cloud.google.com/compute/docs/reference/rest/v1/backendServices)
Expand All @@ -262,17 +262,17 @@ message ExtensionChain {

// Optional. Determines how the proxy behaves if the call to the extension
// fails or times out.
//
// When set to `TRUE`, request or response processing continues without
// error. Any subsequent extensions in the extension chain are also
// executed. When set to `FALSE`:
// * If response headers have not been delivered to the downstream
// client, a generic 500 error is returned to the client. The error
// response can be tailored by configuring a custom error response
// in the load balancer.
// executed. When set to `FALSE` or the default setting of `FALSE` is used,
// one of the following happens:
// * If response headers have not been delivered to the downstream client,
// a generic 500 error is returned to the client. The error response can be
// tailored by configuring a custom error response in the load balancer.
//
// * If response headers have been delivered, then the HTTP stream to
// the downstream client is reset.
// Default is `FALSE`.
// * If response headers have been delivered, then the HTTP stream to the
// downstream client is reset.
bool fail_open = 6 [(google.api.field_behavior) = OPTIONAL];

// Optional. List of the HTTP headers to forward to the extension
Expand Down Expand Up @@ -334,8 +334,9 @@ message LbTrafficExtension {

// Optional. Set of labels associated with the `LbTrafficExtension` resource.
//
// The format must comply with [the following
// requirements](/compute/docs/labeling-resources#requirements).
// The format must comply with [the requirements for
// labels](/compute/docs/labeling-resources#requirements) for Google Cloud
// resources.
map<string, string> labels = 4 [(google.api.field_behavior) = OPTIONAL];

// Required. A list of references to the forwarding rules to which this
Expand Down Expand Up @@ -545,8 +546,9 @@ message LbRouteExtension {

// Optional. Set of labels associated with the `LbRouteExtension` resource.
//
// The format must comply with [the following
// requirements](/compute/docs/labeling-resources#requirements).
// The format must comply with [the requirements for
// labels](/compute/docs/labeling-resources#requirements) for Google Cloud
// resources.
map<string, string> labels = 4 [(google.api.field_behavior) = OPTIONAL];

// Required. A list of references to the forwarding rules to which this
Expand Down

0 comments on commit 2f14a03

Please sign in to comment.