Skip to content

Commit

Permalink
feat: added support routeUpdateWaitTime field for Deployment Strategies
Browse files Browse the repository at this point in the history
Users can specify a non trivial amount of wait time after each route update for deployment strategies.

PiperOrigin-RevId: 546929254
  • Loading branch information
Google APIs authored and Copybara-Service committed Jul 10, 2023
1 parent f1f8ba4 commit a04c947
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 9 deletions.
2 changes: 1 addition & 1 deletion google/cloud/deploy/v1/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ load(

csharp_proto_library(
name = "deploy_csharp_proto",
extra_opts = [],
extra_opts = [""],
deps = [":deploy_proto"],
)

Expand Down
22 changes: 14 additions & 8 deletions google/cloud/deploy/v1/cloud_deploy.proto
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,12 @@ message KubernetesConfig {
// Required. Name of the Kubernetes Deployment whose traffic is managed by
// the specified HTTPRoute and Service.
string deployment = 3 [(google.api.field_behavior) = REQUIRED];

// Optional. The time to wait for route updates to propagate. The maximum
// configurable time is 3 hours, in seconds format. If unspecified, there is
// no wait time.
google.protobuf.Duration route_update_wait_time = 4
[(google.api.field_behavior) = OPTIONAL];
}

// Information about the Kubernetes Service networking configuration.
Expand Down Expand Up @@ -867,17 +873,17 @@ message Target {
// Destination to which the Skaffold configuration is applied during a
// rollout.
oneof deployment_target {
// Information specifying a GKE Cluster.
GkeCluster gke = 15;
// Optional. Information specifying a GKE Cluster.
GkeCluster gke = 15 [(google.api.field_behavior) = OPTIONAL];

// Information specifying an Anthos Cluster.
AnthosCluster anthos_cluster = 17;
// Optional. Information specifying an Anthos Cluster.
AnthosCluster anthos_cluster = 17 [(google.api.field_behavior) = OPTIONAL];

// Information specifying a Cloud Run deployment target.
CloudRunLocation run = 18;
// Optional. Information specifying a Cloud Run deployment target.
CloudRunLocation run = 18 [(google.api.field_behavior) = OPTIONAL];

// Information specifying a multiTarget.
MultiTarget multi_target = 19;
// Optional. Information specifying a multiTarget.
MultiTarget multi_target = 19 [(google.api.field_behavior) = OPTIONAL];
}

// Optional. This checksum is computed by the server based on the value of
Expand Down
6 changes: 6 additions & 0 deletions google/cloud/deploy/v1/log_enums.proto
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ enum Type {
// A Pub/Sub notification failed to be sent.
TYPE_PUBSUB_NOTIFICATION_FAILURE = 1;

// Resource state changed.
TYPE_RESOURCE_STATE_CHANGE = 3;

// A process aborted.
TYPE_PROCESS_ABORTED = 4;

// Deprecated: This field is never used. Use release_render log type instead.
TYPE_RENDER_STATUES_CHANGE = 2 [deprecated = true];
}

0 comments on commit a04c947

Please sign in to comment.