feat: added rpc RenameTagTemplateFieldEnumValue

feat: returning approximate total size for SearchCatalog feat: returning unreachable locations for SearchCatalog feat: added Entry.usage_signal docs: update docs of SearchCatalogRequest message PiperOrigin-RevId: 545732359
googleapis · Jul 5, 2023 · a1098e7 · a1098e7
1 parent e73fc8f
commit a1098e7
Show file tree

Hide file tree

Showing 16 changed files with 539 additions and 229 deletions.
diff --git a/google/cloud/datacatalog/v1/BUILD.bazel b/google/cloud/datacatalog/v1/BUILD.bazel
@@ -93,8 +93,8 @@ java_gapic_library(
     rest_numeric_enums = False,
     service_yaml = "datacatalog_v1.yaml",
     test_deps = [
-        ":datacatalog_java_grpc",
         "//google/iam/v1:iam_java_grpc",
+        ":datacatalog_java_grpc",
     ],
     transport = "grpc+rest",
     deps = [
@@ -247,7 +247,9 @@ php_gapic_library(
     rest_numeric_enums = False,
     service_yaml = "datacatalog_v1.yaml",
     transport = "grpc+rest",
-    deps = [":datacatalog_php_proto"],
+    deps = [
+        ":datacatalog_php_proto",
+    ],
 )
 
 # Open Source Packages
@@ -358,6 +360,7 @@ load(
 
 csharp_proto_library(
     name = "datacatalog_csharp_proto",
+    extra_opts = [],
     deps = [":datacatalog_proto"],
 )
 

diff --git a/google/cloud/datacatalog/v1/datacatalog.proto b/google/cloud/datacatalog/v1/datacatalog.proto
@@ -700,7 +700,7 @@ message SearchCatalogRequest {
   // * `description:z`
   string query = 1 [(google.api.field_behavior) = OPTIONAL];
 
-  // Number of results to return in a single search page.
+  // Upper bound on the number of results you can get in a single response.
   //
   // Can't be negative or 0, defaults to 10 in this case.
   // The maximum number is 1000. If exceeded, throws an "invalid argument"
@@ -725,6 +725,13 @@ message SearchCatalogRequest {
   // * `last_modified_timestamp [asc|desc]` with descending (`desc`) as default
   // * `default` that can only be descending
   //
+  // Search queries don't guarantee full recall. Results that match your query
+  // might not be returned, even in subsequent result pages. Additionally,
+  // returned (and not returned) results can vary if you repeat search queries.
+  // If you are experiencing recall issues and you don't have to fetch the
+  // results in any specific order, consider setting this parameter to
+  // `default`.
+  //
   // If this parameter is omitted, it defaults to the descending `relevance`.
   string order_by = 5;
 }
@@ -1063,10 +1070,8 @@ message Entry {
   // Required. Entry type.
   oneof entry_type {
     // The type of the entry.
-    // Only used for entries with types listed in the `EntryType` enum.
     //
-    // Currently, only `FILESET` enum value is allowed. All other entries
-    // created in Data Catalog must use the `user_specified_type`.
+    // For details, see [`EntryType`](#entrytype).
     EntryType type = 2;
 
     // Custom entry type that doesn't match any of the values allowed for input
@@ -2030,8 +2035,18 @@ message ModifyEntryContactsRequest {
   Contacts contacts = 2 [(google.api.field_behavior) = REQUIRED];
 }
 
-// The enum field that lists all the types of entry resources in Data
-// Catalog. For example, a BigQuery table entry has the `TABLE` type.
+// Metadata automatically ingested from Google Cloud resources like BigQuery
+// tables or Pub/Sub topics always uses enum values from `EntryType` as the type
+// of entry.
+//
+// Other sources of metadata like Hive or Oracle databases can identify the type
+// by either using one of the enum values from `EntryType` (for example,
+// `FILESET` for a Cloud Storage fileset) or specifying a custom value using
+// the [`Entry`](#resource:-entry) field `user_specified_type`. For more
+// information, see
+// [Surface files from Cloud Storage with fileset
+// entries](/data-catalog/docs/how-to/filesets) or [Create custom entries for
+// your data sources](/data-catalog/docs/how-to/custom-entries).
 enum EntryType {
   // Default unknown type.
   ENTRY_TYPE_UNSPECIFIED = 0;
@@ -2040,10 +2055,10 @@ enum EntryType {
   // logical views.
   TABLE = 2;
 
-  // Output only. The type of models.
+  // The type of models.
   //
-  // For more information, see [Supported models in BigQuery ML]
-  // (https://cloud.google.com/bigquery-ml/docs/introduction#supported_models_in).
+  // For more information, see [Supported models in BigQuery
+  // ML](/bigquery/docs/bqml-introduction#supported_models).
   MODEL = 5;
 
   // An entry type for streaming entries. For example, a Pub/Sub topic.
@@ -2059,11 +2074,11 @@ enum EntryType {
   // A database.
   DATABASE = 7;
 
-  // Output only. Connection to a data source. For example, a BigQuery
+  // Connection to a data source. For example, a BigQuery
   // connection.
   DATA_SOURCE_CONNECTION = 8;
 
-  // Output only. Routine, for example, a BigQuery routine.
+  // Routine, for example, a BigQuery routine.
   ROUTINE = 9;
 
   // A Dataplex lake.

diff --git a/google/cloud/datacatalog/v1beta1/BUILD.bazel b/google/cloud/datacatalog/v1beta1/BUILD.bazel
@@ -31,6 +31,7 @@ proto_library(
         "table_spec.proto",
         "tags.proto",
         "timestamps.proto",
+        "usage.proto",
     ],
     deps = [
         "//google/api:annotations_proto",
@@ -39,6 +40,7 @@ proto_library(
         "//google/api:resource_proto",
         "//google/iam/v1:iam_policy_proto",
         "//google/iam/v1:policy_proto",
+        "//google/longrunning:operations_proto",
         "@com_google_protobuf//:empty_proto",
         "@com_google_protobuf//:field_mask_proto",
         "@com_google_protobuf//:timestamp_proto",
@@ -50,6 +52,7 @@ proto_library_with_info(
     deps = [
         ":datacatalog_proto",
         "//google/cloud:common_resources_proto",
+        "//google/iam/v1:iam_policy_proto",
     ],
 )
 
@@ -84,8 +87,8 @@ java_gapic_library(
     rest_numeric_enums = False,
     service_yaml = "datacatalog_v1beta1.yaml",
     test_deps = [
-        ":datacatalog_java_grpc",
         "//google/iam/v1:iam_java_grpc",
+        ":datacatalog_java_grpc",
     ],
     transport = "grpc+rest",
     deps = [
@@ -139,6 +142,7 @@ go_proto_library(
     deps = [
         "//google/api:annotations_go_proto",
         "//google/iam/v1:iam_go_proto",
+        "//google/longrunning:longrunning_go_proto",
     ],
 )
 
@@ -155,6 +159,9 @@ go_gapic_library(
     deps = [
         ":datacatalog_go_proto",
         "//google/iam/v1:iam_go_proto",
+        "//google/longrunning:longrunning_go_proto",
+        "@com_google_cloud_go_longrunning//:go_default_library",
+        "@com_google_cloud_go_longrunning//autogen:go_default_library",
     ],
 )
 
@@ -233,7 +240,9 @@ php_gapic_library(
     rest_numeric_enums = False,
     service_yaml = "datacatalog_v1beta1.yaml",
     transport = "grpc+rest",
-    deps = [":datacatalog_php_proto"],
+    deps = [
+        ":datacatalog_php_proto",
+    ],
 )
 
 # Open Source Packages
@@ -336,6 +345,7 @@ load(
 
 csharp_proto_library(
     name = "datacatalog_csharp_proto",
+    extra_opts = [],
     deps = [":datacatalog_proto"],
 )
 

diff --git a/google/cloud/datacatalog/v1beta1/common.proto b/google/cloud/datacatalog/v1beta1/common.proto
@@ -1,4 +1,4 @@
-// Copyright 2020 Google LLC
+// Copyright 2023 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -36,3 +36,16 @@ enum IntegratedSystem {
   // Cloud Pub/Sub.
   CLOUD_PUBSUB = 2;
 }
+
+// This enum describes all the systems that manage
+// Taxonomy and PolicyTag resources in DataCatalog.
+enum ManagingSystem {
+  // Default value
+  MANAGING_SYSTEM_UNSPECIFIED = 0;
+
+  // Dataplex.
+  MANAGING_SYSTEM_DATAPLEX = 1;
+
+  // Other
+  MANAGING_SYSTEM_OTHER = 2;
+}