Skip to content

Commit

Permalink
fix: change the config service's Ruby namespace to avoid a collision …
Browse files Browse the repository at this point in the history
…with a base class in the Ruby client platform

PiperOrigin-RevId: 566731818
  • Loading branch information
Google APIs authored and Copybara-Service committed Sep 19, 2023
1 parent 449fb60 commit cc3cba1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions google/cloud/config/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This build file includes a target for the Ruby wrapper library for
# google-cloud-config.
# google-cloud-config_service.

# This is an API workspace, having public visibility by default makes perfect sense.
package(default_visibility = ["//visibility:public"])
Expand All @@ -20,7 +20,7 @@ ruby_cloud_gapic_library(
name = "config_ruby_wrapper",
srcs = ["//google/cloud/config/v1:config_proto_with_info"],
extra_protoc_parameters = [
"ruby-cloud-gem-name=google-cloud-config",
"ruby-cloud-gem-name=google-cloud-config_service",
"ruby-cloud-wrapper-of=v1:0.0",
],
service_yaml = "//google/cloud/config/v1:config_v1.yaml",
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/config/v1/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ ruby_cloud_gapic_library(
name = "config_ruby_gapic",
srcs = [":config_proto_with_info"],
extra_protoc_parameters = [
"ruby-cloud-gem-name=google-cloud-config-v1",
"ruby-cloud-gem-name=google-cloud-config_service-v1",
],
grpc_service_config = None,
rest_numeric_enums = True,
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/config/v1/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ option java_multiple_files = true;
option java_outer_classname = "ConfigProto";
option java_package = "com.google.cloud.config.v1";
option php_namespace = "Google\\Cloud\\Config\\V1";
option ruby_package = "Google::Cloud::Config::V1";
option ruby_package = "Google::Cloud::ConfigService::V1";
option (google.api.resource_definition) = {
type: "iam.googleapis.com/ServiceAccount"
pattern: "projects/{project}/serviceAccounts/{service_account}"
Expand Down

0 comments on commit cc3cba1

Please sign in to comment.