Skip to content

Commit

Permalink
docs: minor updates in comments
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 491785685
  • Loading branch information
Google APIs authored and Copybara-Service committed Nov 30, 2022
1 parent dc4d319 commit e8bd0c4
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 12 deletions.
20 changes: 16 additions & 4 deletions google/cloud/tpu/v1/BUILD.bazel
Expand Up @@ -38,6 +38,7 @@ proto_library_with_info(
deps = [
":tpu_proto",
"//google/cloud:common_resources_proto",
"//google/cloud/location:location_proto",
],
)

Expand Down Expand Up @@ -67,14 +68,19 @@ java_grpc_library(
java_gapic_library(
name = "tpu_java_gapic",
srcs = [":tpu_proto_with_info"],
gapic_yaml = None,
grpc_service_config = "tpu_grpc_service_config.json",
rest_numeric_enums = False,
service_yaml = "tpu_v1.yaml",
test_deps = [
":tpu_java_grpc",
"//google/cloud/location:location_java_grpc",
],
transport = "grpc",
deps = [
":tpu_java_proto",
"//google/api:api_java_proto",
"//google/cloud/location:location_java_proto",
],
)

Expand All @@ -90,7 +96,7 @@ java_gapic_test(
java_gapic_assembly_gradle_pkg(
name = "google-cloud-tpu-v1-java",
include_samples = True,
transport = "grpc",
transport = "grpc+rest",
deps = [
":tpu_java_gapic",
":tpu_java_grpc",
Expand Down Expand Up @@ -129,8 +135,10 @@ go_gapic_library(
metadata = True,
rest_numeric_enums = False,
service_yaml = "tpu_v1.yaml",
transport = "grpc+rest",
deps = [
":tpu_go_proto",
"//google/cloud/location:location_go_proto",
"//google/longrunning:longrunning_go_proto",
"@com_google_cloud_go//longrunning:go_default_library",
"@com_google_cloud_go//longrunning/autogen:go_default_library",
Expand Down Expand Up @@ -170,7 +178,10 @@ py_gapic_library(
srcs = [":tpu_proto"],
grpc_service_config = "tpu_grpc_service_config.json",
rest_numeric_enums = False,
service_yaml = "tpu_v1.yaml",
transport = "grpc",
deps = [
],
)

py_test(
Expand Down Expand Up @@ -292,16 +303,17 @@ ruby_cloud_gapic_library(
name = "tpu_ruby_gapic",
srcs = [":tpu_proto_with_info"],
extra_protoc_parameters = [
"ruby-cloud-gem-name=google-cloud-tpu-v1",
"ruby-cloud-env-prefix=CLOUD_TPU",
"ruby-cloud-product-url=https://cloud.google.com/tpu/",
"ruby-cloud-api-id=tpu.googleapis.com",
"ruby-cloud-api-shortname=tpu",
"ruby-cloud-env-prefix=CLOUD_TPU",
"ruby-cloud-gem-name=google-cloud-tpu-v1",
"ruby-cloud-product-url=https://cloud.google.com/tpu/",
],
grpc_service_config = "tpu_grpc_service_config.json",
rest_numeric_enums = False,
ruby_cloud_description = "Tensor Processing Units (TPUs) are Google's custom-developed application-specific integrated circuits (ASICs) used to accelerate machine learning workloads. Cloud TPUs allow you to access TPUs from Compute Engine, Google Kubernetes Engine and AI Platform.",
ruby_cloud_title = "Cloud TPU V1",
service_yaml = "tpu_v1.yaml",
deps = [
":tpu_ruby_grpc",
":tpu_ruby_proto",
Expand Down
11 changes: 3 additions & 8 deletions google/cloud/tpu/v1/cloud_tpu.proto
@@ -1,4 +1,4 @@
// Copyright 2021 Google LLC
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -88,7 +88,7 @@ service Tpu {
};
}

// Stops a node.
// Stops a node, this operation is only available with single TPU nodes.
rpc StopNode(StopNodeRequest) returns (google.longrunning.Operation) {
option (google.api.http) = {
post: "/v1/{name=projects/*/locations/*/nodes/*}:stop"
Expand Down Expand Up @@ -178,7 +178,7 @@ message Node {
// TPU node is being created.
CREATING = 1;

// TPU node has been created and is fully usable.
// TPU node has been created.
READY = 2;

// TPU node is restarting.
Expand Down Expand Up @@ -550,11 +550,6 @@ message ListAcceleratorTypesResponse {
repeated string unreachable = 3;
}

// Note: the following OperationMetadata message was added manually.
// This is caused by a conflict with some other message and will
// be resolved separately. Please make sure to add this message back
// if it's removed during public proto regeneration.

// Metadata describing an [Operation][google.longrunning.Operation]
message OperationMetadata {
// The time the operation was created.
Expand Down
2 changes: 2 additions & 0 deletions google/cloud/tpu/v1/tpu_v1.yaml
Expand Up @@ -4,7 +4,9 @@ name: tpu.googleapis.com
title: Cloud TPU API

apis:
- name: google.cloud.location.Locations
- name: google.cloud.tpu.v1.Tpu
- name: google.longrunning.Operations

types:
- name: google.cloud.tpu.v1.OperationMetadata
Expand Down

0 comments on commit e8bd0c4

Please sign in to comment.