Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move compute_small protos under its own directory #681

Merged
merged 4 commits into from Nov 12, 2021
Merged

fix: Move compute_small protos under its own directory #681

merged 4 commits into from Nov 12, 2021

Conversation

vam-google
Copy link
Collaborator

This is needed to fix API index.
Also removed gapic_yaml file, as it is not needed anymore.

@vam-google
fix: Move compute_small protos under its own directory
e36f258 
This is needed to fix API index.
Also removed gapic_yaml file, as it is not needed anymore.
@mistaken-pull-closer
Copy link

Thanks for your contribution! Unfortunately, we don't use GitHub pull
requests to manage code contributions to this repository. Instead, please
see CONTRIBUTING.md which provides full
instructions on how to get involved.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2021
@vam-google vam-google reopened this Nov 12, 2021
jskeet
jskeet approved these changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vadym!

@vchudnov-g
Copy link
Contributor

I suggest adding a README to the small directory explaining what it's for: it's not the full API and the files there are just to make development easier.

@vam-google
Copy link
Collaborator Author

@vchudnov-g Added README.md, PTAL.

vchudnov-g
vchudnov-g approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Two minor comments.

google/cloud/compute/v1small/README.md Outdated
@@ -0,0 +1,8 @@
# Google Compute Engine Minimal API (for Testing Purposes Only)

Minimal viable set of API methods from [GCE](https://cloud.google.com/error-reporting/reference/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would spell out Google Compute Engine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

google/cloud/compute/v1small/README.md Outdated

Minimal viable set of API methods from [GCE](https://cloud.google.com/error-reporting/reference/).

These API definitions exist only for testing and to simplyfy development of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp: simplify

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vam-google vam-google merged commit 97cabab into googleapis:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
4 participants
@vam-google @vchudnov-g @jskeet @alexander-fenster