feat(bazel): make googleapis a Bzlmod module #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
commented
Mar 27, 2024
| switched_rules.use_languages( | ||
| cc = True, | ||
| # csharp = True, | ||
| # gapic = True, |
There was a problem hiding this comment.
i left some of these out, which means not everything in the repo builds with bzlmod enabled, in order to support each of these we'll have to move their deps to bzlmod, which is potentially difficult depending on their transitives
|
|
||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| _disco_to_proto3_converter_version = "74c0ede1e6871c878de6c3cab3ef152280c6518f" |
There was a problem hiding this comment.
they aren't. i didn't handle all the different language specific dependencies here, and this one is one that was easy enough to throw here so that a few more targets built when testing the integration in this repo.
|
the dependency is merged so this is reviewable now! |
meteorcloudy
approved these changes
Apr 15, 2024
|
@meteorcloudy could you help route this? |
|
I'll ask around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on bazelbuild/bazel-central-registry#1699 because of a circular dependency on grpc-java
This is based on #855 with some fixes