Skip to content

Commit

Permalink
test: Improve code coverage for Acl
Browse files Browse the repository at this point in the history
In Acl there's still untested class particularly the IamMember.
Also we can still improve the coverage by improving test for Group.
  • Loading branch information
Irvi Firqotul Aini committed Jun 26, 2020
1 parent 12a2bea commit 743dd6e
Showing 1 changed file with 17 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.google.cloud.bigquery.Acl.Role;
import com.google.cloud.bigquery.Acl.User;
import com.google.cloud.bigquery.Acl.View;
import com.google.cloud.bigquery.Acl.IamMember;
import org.junit.Test;

public class AclTest {
Expand All @@ -52,12 +53,20 @@ public void testGroupEntity() {
public void testSpecialGroupEntity() {
Group entity = Group.ofAllAuthenticatedUsers();
assertEquals("allAuthenticatedUsers", entity.getIdentifier());
Dataset.Access pb = entity.toPb();
assertEquals(entity, Entity.fromPb(pb));
entity = Group.ofProjectWriters();
assertEquals("projectWriters", entity.getIdentifier());
pb = entity.toPb();
assertEquals(entity, Entity.fromPb(pb));
entity = Group.ofProjectReaders();
assertEquals("projectReaders", entity.getIdentifier());
pb = entity.toPb();
assertEquals(entity, Entity.fromPb(pb));
entity = Group.ofProjectOwners();
assertEquals("projectOwners", entity.getIdentifier());
pb = entity.toPb();
assertEquals(entity, Entity.fromPb(pb));
}

@Test
Expand All @@ -79,6 +88,14 @@ public void testViewEntity() {
assertEquals(entity, Entity.fromPb(pb));
}

@Test
public void testIamMemberEntity() {
IamMember entity = new IamMember("member1");
assertEquals("member1", entity.getIamMember());
Dataset.Access pb = entity.toPb();
assertEquals(entity, Entity.fromPb(pb));
}

@Test
public void testOf() {
Acl acl = Acl.of(Group.ofAllAuthenticatedUsers(), Role.READER);
Expand Down

0 comments on commit 743dd6e

Please sign in to comment.