Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove assertj.core if possible #2083

Closed
stephaniewang526 opened this issue May 31, 2022 · 0 comments · Fixed by #2102
Closed

chore: remove assertj.core if possible #2083

stephaniewang526 opened this issue May 31, 2022 · 0 comments · Fixed by #2102
Assignees
@prash-mi
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. type: cleanup An internal cleanup or hygiene concern.

Comments

@stephaniewang526
Copy link
Contributor

org.assertj.core.api.Assertions.* is currently used in QueryRequestInfoTest only. If we can find an equivalent in junit or alike then we should remove this dependency.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label May 31, 2022
@stephaniewang526 stephaniewang526 mentioned this issue May 31, 2022
Merged
@meredithslota meredithslota added the type: cleanup An internal cleanup or hygiene concern. label Jun 1, 2022
@prash-mi prash-mi mentioned this issue Jun 7, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 7, 2022
@prash-mi
fix: Assertj-core cleanup (#2102)
4630c50 
Removed Assertj-core  and refactored related testcase

Fixes #2083☕️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prash-mi prash-mi

Labels
api: bigquery Issues related to the googleapis/java-bigquery API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Assertj-core cleanup prash-mi/java-bigquery
3 participants
@meredithslota @stephaniewang526 @prash-mi