Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for DecimalTargetTypes #1345

Merged
merged 5 commits into from Jun 8, 2021

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jun 2, 2021

Towards b/188414733
Implemented in LoadJobConfiguration and ExternalTableDefinition

cc @MingyuZhong

Towards b/188414733
Implemented in LoadJobConfiguration
@stephaniewang526 stephaniewang526 requested a review from as a code owner Jun 2, 2021
@stephaniewang526 stephaniewang526 requested a review from prash-mi Jun 2, 2021
@product-auto-label product-auto-label bot added the api: bigquery label Jun 2, 2021
@google-cla google-cla bot added the cla: yes label Jun 2, 2021
@stephaniewang526 stephaniewang526 removed the request for review from prash-mi Jun 2, 2021
@stephaniewang526 stephaniewang526 marked this pull request as draft Jun 2, 2021
@stephaniewang526 stephaniewang526 marked this pull request as ready for review Jun 7, 2021
@stephaniewang526 stephaniewang526 requested a review from as a code owner Jun 7, 2021
@stephaniewang526 stephaniewang526 requested a review from shollyman Jun 7, 2021
@stephaniewang526 stephaniewang526 changed the title feat: add support for DecimalTargetType feat: add support for DecimalTargetTypes Jun 7, 2021
Copy link
Contributor

@shollyman shollyman left a comment

Nice, I like the exercise of the precision/scale validation in the integration test.

@stephaniewang526 stephaniewang526 added the do not merge label Jun 8, 2021
@stephaniewang526
Copy link
Member Author

@stephaniewang526 stephaniewang526 commented Jun 8, 2021

Will not merge until the UI change reaches golden.

@stephaniewang526 stephaniewang526 removed the do not merge label Jun 8, 2021
@stephaniewang526 stephaniewang526 merged commit ba528df into googleapis:master Jun 8, 2021
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants