Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flaky testPositionalQueryParameters #2059

Conversation

prash-mi
Copy link
Contributor

String comparison of values, eg 1.40845209522E9 vs 1408452095.22 seems to be failing, so comparing the values as epoc (Long) instead

Fixes #2056 ☕️

@prash-mi prash-mi requested a review from a team May 23, 2022 05:54
@prash-mi prash-mi requested a review from gnanda May 23, 2022 05:54
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels May 23, 2022
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2022
@stephaniewang526 stephaniewang526 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3764b59 into googleapis:main May 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request May 25, 2022
🤖 I have created a release *beep* *boop*
---


## [2.12.0](v2.11.2...v2.12.0) (2022-05-25)


### Features

* add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#2057](#2057)) ([065ae78](065ae78))


### Bug Fixes

* add more native image configurations for Arrow tests and enable native image tests ([#2053](#2053)) ([7f0bfd4](7f0bfd4))
* Flaky testPositionalQueryParameters ([#2059](#2059)) ([3764b59](3764b59))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigtable to v2.7.0 ([#2061](#2061)) ([1c7a0ab](1c7a0ab))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#2055](#2055)) ([9667663](9667663))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#2063](#2063)) ([6d3f4be](6d3f4be))
* update dependency com.google.cloud:google-cloud-storage to v2.7.0 ([#2064](#2064)) ([fd47710](fd47710))
* update dependency com.google.cloud:google-cloud-storage to v2.7.1 ([#2066](#2066)) ([89962a5](89962a5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery.it.ITBigQueryTest: testPositionalQueryParameters failed
2 participants