Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove @InternalApi from TableResult #3257

Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix: Remove @InternalApi from TableResult #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d67387f
fix: Remove @InternalApi from TableResult
PhongChuong Apr 22, 2024
be7528d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 22, 2024
49972b1
Remove clirr ignore difference entries for TableResult
PhongChuong Apr 22, 2024
a577112
Merge remote-tracking branch 'origin/3215TableResultInternalApi' into…
PhongChuong Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 0 additions & 38 deletions google-cloud-bigquery/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,6 @@
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!-- TODO: REMOVE AFTER RELEASE -->
<difference>
<differenceType>3005</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<justification>TableResult is an internal API and it should be fine to update</justification>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<method>*TableResult(*)</method>
<justification>TableResult is an internal API and it should be fine to update</justification>
</difference>
<difference>
<differenceType>7004</differenceType>
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
Expand All @@ -25,19 +14,6 @@
<method>com.google.api.services.bigquery.model.GetQueryResultsResponse getQueryResultsWithRowLimit(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)</method>
<justification>getQueryResultsWithRowLimit is just used by ConnectionImpl at the moment so it should be fine to update the signature instead of writing an overloaded method</justification>
</difference>
<difference>
<differenceType>7004</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<method>*TableResult(*)</method>
<justification>It should be fine to update TableResult constructors since it is used to return results to the user and users should not directly construct TableResult objects</justification>
</difference>
<difference>
<differenceType>7005</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<method>*TableResult(*)</method>
<to>*TableResult(*)</to>
<justification>It should be fine to update TableResult constructors since it is used to return results to the user and users should not directly construct TableResult objects</justification>
</difference>
<difference>
<differenceType>7013</differenceType>
<className>com/google/cloud/bigquery/ExternalTableDefinition*</className>
Expand All @@ -58,16 +34,6 @@
<className>com/google/cloud/bigquery/TableInfo*</className>
<method>*ResourceTags(*)</method>
</difference>
<difference>
<differenceType>7013</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<method>*getPageNoSchema(*)</method>
</difference>
<difference>
<differenceType>7013</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<method>*toBuilder(*)</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/Connection</className>
Expand Down Expand Up @@ -163,8 +129,4 @@
<className>com/google/cloud/bigquery/StandardTableDefinition*</className>
<method>*BigLakeConfiguration(*)</method>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/bigquery/EmptyTableResult*</className>
</difference>
</differences>
2 changes: 0 additions & 2 deletions google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.google.cloud.bigquery;

import com.google.api.core.InternalApi;
import com.google.api.gax.paging.Page;
import com.google.auto.value.AutoValue;
import com.google.common.base.Function;
Expand All @@ -27,7 +26,6 @@
import java.util.Objects;
import javax.annotation.Nullable;

@InternalApi
@AutoValue
public abstract class TableResult implements Page<FieldValueList>, Serializable {

Expand Down