Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BIGNUMERIC support #703

Merged
merged 4 commits into from Nov 19, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Aug 27, 2020

Expose BIGNUMERIC type in the client

cc: @MingyuZhong

@google-cla google-cla bot added the cla: yes label Aug 27, 2020
@stephaniewang526 stephaniewang526 marked this pull request as draft Aug 27, 2020
@product-auto-label product-auto-label bot added the api: bigquery label Aug 28, 2020
update IT testcase

nit
@stephaniewang526 stephaniewang526 marked this pull request as ready for review Aug 28, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 28, 2020

Codecov Report

Merging #703 (f021dde) into master (f59241b) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #703      +/-   ##
============================================
+ Coverage     80.40%   81.07%   +0.67%     
+ Complexity     1271     1237      -34     
============================================
  Files            79       78       -1     
  Lines          6573     6336     -237     
  Branches        758      703      -55     
============================================
- Hits           5285     5137     -148     
+ Misses          893      833      -60     
+ Partials        395      366      -29     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/bigquery/LegacySQLTypeName.java 95.34% <100.00%> (+0.22%) 7.00 <0.00> (ø)
...com/google/cloud/bigquery/QueryParameterValue.java 81.86% <100.00%> (+0.08%) 61.00 <1.00> (+1.00)
...com/google/cloud/bigquery/StandardSQLTypeName.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...google/cloud/bigquery/HivePartitioningOptions.java 83.78% <0.00%> (-1.64%) 11.00% <0.00%> (-2.00%)
...y/src/main/java/com/google/cloud/bigquery/Acl.java 71.42% <0.00%> (-0.58%) 13.00% <0.00%> (-1.00%)
...google/cloud/bigquery/ExternalTableDefinition.java 58.09% <0.00%> (-0.47%) 19.00% <0.00%> (-2.00%)
...m/google/cloud/bigquery/QueryJobConfiguration.java 90.08% <0.00%> (-0.27%) 66.00% <0.00%> (-2.00%)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 82.84% <0.00%> (-0.24%) 77.00% <0.00%> (-9.00%)
...main/java/com/google/cloud/bigquery/FieldList.java 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/TimePartitioning.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59241b...f517a6b. Read the comment docs.

Copy link

@MingyuZhong MingyuZhong left a comment

Thanks!

@stephaniewang526 stephaniewang526 added the do not merge label Aug 28, 2020
@stephaniewang526
Copy link
Member Author

@stephaniewang526 stephaniewang526 commented Aug 28, 2020

Cannot merge until BigQuery backend is ready.

@shollyman
Copy link
Contributor

@shollyman shollyman commented Nov 19, 2020

Modulo any updates bringing this PR back in line with master, this should be good to merge now.

@stephaniewang526 stephaniewang526 requested a review from as a code owner Nov 19, 2020
@stephaniewang526 stephaniewang526 removed the do not merge label Nov 19, 2020
@stephaniewang526 stephaniewang526 added the automerge label Nov 19, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 718ec2a into googleapis:master Nov 19, 2020
16 of 18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Nov 19, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants