Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add export query results to Amazon S3 sample and IT #853

Merged
merged 2 commits into from Oct 23, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Oct 23, 2020

No description provided.

@stephaniewang526 stephaniewang526 requested a review from Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@stephaniewang526 stephaniewang526 requested a review from pmakani Oct 23, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 23, 2020

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #853   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity     1268     1268           
=========================================
  Files            79       79           
  Lines          6548     6548           
  Branches        749      749           
=========================================
  Hits           5263     5263           
  Misses          892      892           
  Partials        393      393           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f44f74...bcff9b8. Read the comment docs.

lesv
lesv approved these changes Oct 23, 2020
lesv
lesv approved these changes Oct 23, 2020
Copy link

@lesv lesv left a comment

Note - please add a comment for bucket name and consider elharo's suggestions.

@stephaniewang526 stephaniewang526 added the automerge label Oct 23, 2020
@stephaniewang526 stephaniewang526 merged commit 5358620 into googleapis:master Oct 23, 2020
21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 23, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants