Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-implement resource name helper classes #59

Merged
merged 7 commits into from Mar 5, 2020

Conversation

yihanzhen
Copy link
Contributor

@yihanzhen yihanzhen commented Feb 21, 2020

  • Delete ParentName, ParentNames and UntypedParentName
  • Generate two overloads for methods that take ParentName as a parameter, changing to LocationName and ProjectName respectively
  • Deprecate LocationRunName, ProjectRunName, LocationTransferConfigName, ProjectTransferConfigName, LocationDataSourceName, ProjectDataSourceName, the functionality is replaced by the new multi-pattern resource name helper classes: RunName, TransferConfigName and DataSourceName.
  • New methods in RunName, TransferConfigName and DataSourceName are marked as @betaApi.

@googlebot googlebot added the cla: yes label Feb 21, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 21, 2020

Codecov Report

Merging #59 into master will decrease coverage by 1.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage     75.65%   74.35%   -1.30%     
  Complexity      108      108              
============================================
  Files             7        7              
  Lines           920      936      +16     
  Branches         15       18       +3     
============================================
  Hits            696      696              
- Misses          204      220      +16     
  Partials         20       20              
Impacted Files Coverage Δ Complexity Δ
...ery/datatransfer/v1/DataTransferServiceClient.java 61.88% <0.00%> (-4.35%) 57.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c9119...cd4e87c. Read the comment docs.

@yihanzhen yihanzhen requested a review from chingor13 Feb 21, 2020
@yihanzhen
Copy link
Contributor Author

@yihanzhen yihanzhen commented Feb 21, 2020

@chingor13 Hey Jeff, how do I disable binary compatibility check?

@chingor13 chingor13 changed the title feat: reimplement resource name helper classes feat!: reimplement resource name helper classes Feb 24, 2020
@yihanzhen
Copy link
Contributor Author

@yihanzhen yihanzhen commented Mar 4, 2020

@stephaniewang526 stephaniewang526 changed the title feat!: reimplement resource name helper classes feat: re-implement resource name helper classes Mar 5, 2020
@stephaniewang526 stephaniewang526 merged commit d1cc550 into googleapis:master Mar 5, 2020
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants