New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-implement resource name helper classes #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
============================================
- Coverage 75.65% 74.35% -1.30%
Complexity 108 108
============================================
Files 7 7
Lines 920 936 +16
Branches 15 18 +3
============================================
Hits 696 696
- Misses 204 220 +16
Partials 20 20
Continue to review full report at Codecov.
|
@chingor13 Hey Jeff, how do I disable binary compatibility check? |
yihanzhen
reviewed
Mar 4, 2020
...ain/java/com/google/cloud/bigquery/datatransfer/v1/stub/DataTransferServiceStubSettings.java
Show resolved
Hide resolved
@stephaniewang526 PTAL |
stephaniewang526
approved these changes
Mar 5, 2020
...ain/java/com/google/cloud/bigquery/datatransfer/v1/stub/DataTransferServiceStubSettings.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
ParentName
,ParentNames
andUntypedParentName
ParentName
as a parameter, changing toLocationName
andProjectName
respectivelyLocationRunName
,ProjectRunName
,LocationTransferConfigName
,ProjectTransferConfigName
,LocationDataSourceName
,ProjectDataSourceName
, the functionality is replaced by the new multi-pattern resource name helper classes:RunName
,TransferConfigName
andDataSourceName
.RunName
,TransferConfigName
andDataSourceName
are marked as@betaApi
.