feat: add support for proto3 optional tag (#2295)

googleapis · Oct 31, 2023 · bc88aa5 · bc88aa5
1 parent fd8aaae
commit bc88aa5
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/...querystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ProtoSchemaConverter.java b/...querystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ProtoSchemaConverter.java
@@ -102,6 +102,17 @@ private static ProtoSchema convertInternal(
           enumTypes.add(enumFullName);
         }
       }
+      // The protobuf payload will be decoded as proto2 on the server side. The schema is also
+      // specified as proto2. Hence we must clear proto3-only features. This works since proto2 and
+      // proto3 are binary-compatible.
+      if (resultField.hasProto3Optional()) {
+        // Clear proto3-only features
+        resultField.clearProto3Optional();
+      }
+      if (resultField.hasOneofIndex()) {
+        // Clear proto3-only features
+        resultField.clearOneofIndex();
+      }
       resultProto.addField(resultField);
     }
     structTypes.add(protoFullName);