Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand bytes field type handling #1180

Merged
merged 4 commits into from Jul 14, 2021
Merged

Conversation

JacobStocklass
Copy link
Contributor

@JacobStocklass JacobStocklass commented Jul 8, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

Add the ability for a single BYTES field to handle a JSONArray of bytes, and add the ability for a repeated BYTES field to handle a ByteString.
Index to i
@JacobStocklass JacobStocklass requested a review from yirutang Jul 8, 2021
@JacobStocklass JacobStocklass requested a review from as a code owner Jul 8, 2021
@JacobStocklass JacobStocklass requested a review from loferris Jul 8, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Jul 8, 2021
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@stephaniewang526 stephaniewang526 removed the request for review from loferris Jul 9, 2021
@shollyman shollyman requested a review from stephaniewang526 Jul 9, 2021
@stephaniewang526 stephaniewang526 merged commit aab33a5 into master Jul 14, 2021
18 checks passed
@stephaniewang526 stephaniewang526 deleted the JacobStocklass-patch-1 branch Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants