New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update method doc for v1 ReadRowsRequest methods #1389
chore: update method doc for v1 ReadRowsRequest methods #1389
Conversation
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jhambleton , thank you for your contribution!
Please amend your initial commit message to "chore: update method doc for v1 ReadRowsRequest methods" since fix
will trigger a client lib minor version bump and this is not it. It would also clear the conventionalcommit failure you're seeing here.
ef8fde2
to
058bcd2
Compare
thanks @stephaniewang526 for the quick feedback! Updated PR title & initial commit. Keep me posted if you spot anything else. appreciate it. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
update for ReadRowsRequest docs, including java doc, for methods which are inaccurate.
fix will help clarify usage for end users of the sdk