Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: even better ISO compilance #1607

Merged
merged 1 commit into from Apr 8, 2022
Merged

fix: even better ISO compilance #1607

merged 1 commit into from Apr 8, 2022

Conversation

dark0dave
Copy link
Contributor

Fixes #1580

@dark0dave dark0dave requested a review from a team April 5, 2022 12:08
@dark0dave dark0dave requested a review from a team as a code owner April 5, 2022 12:08
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Apr 5, 2022
Using docs from google
https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-json#data_types
as guide, for how types should be parsed

Signed-off-by: dark0dave <dark0dave@mykolab.com>
@dark0dave
Copy link
Contributor Author

@stephaniewang526 as discussed find the updates here. Let me know if any integration tests fail.

@dark0dave
Copy link
Contributor Author

@stephaniewang526 let me know if you require any more changes to merge this.

@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2022
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2022
@stephaniewang526
Copy link
Contributor

@stephaniewang526 let me know if you require any more changes to merge this.

LGTM. Thank you!

@stephaniewang526 stephaniewang526 merged commit 5701597 into googleapis:main Apr 8, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 8, 2022
🤖 I have created a release *beep* *boop*
---


### [2.12.1](v2.12.0...v2.12.1) (2022-04-08)


### Bug Fixes

* even better ISO compilance ([#1607](#1607)) ([5701597](5701597))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.10.6 ([#1610](#1610)) ([20e4225](20e4225))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@dark0dave dark0dave deleted the fix/ISO8601updates branch March 31, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Storage Write API: ISO 8601 timestamp not supported in JsonStreamWriter
3 participants