feat!: remove a dummy WriterClosedException #1726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a dummy WriterClosedException. Because we now have StreamWriterClosedException, remove the WriterClosedException to avoid confusion.
The WriterClosedException is used as a place holder when we cleanup Inflight request. In call cases, we should have gotten a not null connectionFinalStatus in WaitForDoneCallback:
https://github.com/googleapis/java-bigquerystorage/blob/main/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java#L533
So no user should be able to get this exception.
BEGIN_COMMIT_OVERRIDE
feat: remove a dummy WriterClosedException
END_COMMIT_OVERRIDE