Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Numeric/BigNumeric type conversion issue #1768

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

sandhusanthakumar
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1757 ☕️

If you write sample code, please follow the samples format.

@sandhusanthakumar sandhusanthakumar requested review from a team and aribray August 30, 2022 07:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Aug 30, 2022
@sandhusanthakumar sandhusanthakumar changed the title Fix for Numeric/BigNumeric type conversion issue #1757 Fix for Numeric/BigNumeric type conversion issue Aug 30, 2022
@sandhusanthakumar sandhusanthakumar marked this pull request as draft August 30, 2022 07:37
@sandhusanthakumar sandhusanthakumar changed the title Fix for Numeric/BigNumeric type conversion issue fix(api): Numeric/BigNumeric type conversion issue Aug 30, 2022
@sandhusanthakumar sandhusanthakumar marked this pull request as ready for review August 30, 2022 07:54
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@Neenu1995 Neenu1995 merged commit 5cc96a0 into googleapis:main Aug 30, 2022
@sandhusanthakumar sandhusanthakumar deleted the fix-for-#1757 branch August 31, 2022 06:47
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---


## [2.21.0](v2.20.1...v2.21.0) (2022-09-15)


### Features

* Add connection worker skeleton used for multiplexing client ([#1778](#1778)) ([b26265e](b26265e))
* Add Load api for connection worker for multiplexing worker ([#1779](#1779)) ([179930e](179930e))
* Add location to WriteStream and add WriteStreamView support ([#1771](#1771)) ([f446ff4](f446ff4))
* Add proto annotation for non-ascii field mapping ([#1776](#1776)) ([1a079ee](1a079ee))
* introducing connection worker to run a loop for fetching / sending requests in a queue. ([7dd447d](7dd447d))


### Bug Fixes

* **api:** Numeric/bignumeric conversion issue [#1757](#1757) ([#1768](#1768)) ([5cc96a0](5cc96a0))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1766](#1766)) ([40e0ba0](40e0ba0))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1777](#1777)) ([08a7c8f](08a7c8f))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 ([#1781](#1781)) ([7ff7099](7ff7099))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1772](#1772)) ([3279ef4](3279ef4))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1780](#1780)) ([ed2cd66](ed2cd66))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Feb 21, 2023
This should fix release script reporting back to the release PRs
Source-Link: googleapis/synthtool@4c15ec0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e62f3ea524b11c1cd6ff7f80362736d86c0056631346b5b106a421686fce2726
Neenu1995 pushed a commit that referenced this pull request Feb 22, 2023
…2005)

This should fix release script reporting back to the release PRs
Source-Link: googleapis/synthtool@4c15ec0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e62f3ea524b11c1cd6ff7f80362736d86c0056631346b5b106a421686fce2726

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…is#1768) (googleapis#1123)

This should fix release script reporting back to the release PRs
Source-Link: googleapis/synthtool@4c15ec0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e62f3ea524b11c1cd6ff7f80362736d86c0056631346b5b106a421686fce2726

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using JsonStreamWriter for Numeric Types
3 participants