Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigdecimal): Convert BigDecimal to BigNumeric instead of Numeric #2030

Closed

Conversation

rdebokx
Copy link

@rdebokx rdebokx commented Mar 3, 2023

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2013

@rdebokx rdebokx requested review from a team and prash-mi March 3, 2023 09:54
@google-cla
Copy link

google-cla bot commented Mar 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 3, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 3, 2023
@yirutang
Copy link
Contributor

yirutang commented Mar 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This and it seems owl is still failing.

@rdebokx
Copy link
Author

rdebokx commented Mar 6, 2023

@yirutang tnx for getting back to this.
I've resubmitted the CLA from the primary email of this GH account. There should be a CLA both for the accounts that committed to the branch and the one that created this PR. Can the CLA check be re-run?

What error is the owl bot running into? I can confirm that this PR allows edits from maintainers (see below screenshot)
Screenshot 2023-03-06 at 08 43 53

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2023
@yirutang
Copy link
Contributor

yirutang commented Mar 7, 2023

@yirutang tnx for getting back to this. I've resubmitted the CLA from the primary email of this GH account. There should be a CLA both for the accounts that committed to the branch and the one that created this PR. Can the CLA check be re-run?

What error is the owl bot running into? I can confirm that this PR allows edits from maintainers (see below screenshot) Screenshot 2023-03-06 at 08 43 53

I rerun both tasks and owl is still failing, I am asking java lib owner to take a look.

@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2023
@Neenu1995 Neenu1995 closed this Mar 7, 2023
@Neenu1995 Neenu1995 reopened this Mar 7, 2023
@Neenu1995
Copy link
Contributor

Hi @rdebokx ,
I suspect the owlbot is not able to update this PR even with the maintainers are allowed to edit option because
this PR is forked from the old fork(in your org). So the permission restrictions still apply.

My suggestion is to create a new PR from a fork directly from this repo. Or I could duplicate this PR, but that would mean you don't get the commit in your name.

I would prefer you open the PR again, that way you get the credit that's due.

Let me know how you want to proceed and thanks for contributing.

@rdebokx rdebokx closed this Mar 8, 2023
@rdebokx
Copy link
Author

rdebokx commented Mar 8, 2023

Thanks again for looking into this @Neenu1995 . I've created a fresh fork from my work account (but not as organization), and recreated the PR: #2031

Hopefully this will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Storage Write API: JsonStreamWriter cannot transform BigDecimal with 9+ decimals to BigNumeric
3 participants