Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add client id and update trace id population for StreamWriter and JsonWriter #2389

Merged
merged 12 commits into from Feb 7, 2024
Merged

fix: add client id and update trace id population for StreamWriter and JsonWriter #2389

merged 12 commits into from Feb 7, 2024

Conversation

yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested a review from a team as a code owner January 31, 2024 23:05
@yirutang yirutang requested a review from kiraksi January 31, 2024 23:05
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jan 31, 2024
@yirutang yirutang changed the title fix: add client id for StreamWriter fix: add client id and update trace id population for StreamWriter and JsonWriter. Feb 2, 2024
@yirutang yirutang changed the title fix: add client id and update trace id population for StreamWriter and JsonWriter. fix: add client id and update trace id population for StreamWriter and JsonWriter Feb 2, 2024
@yirutang yirutang requested a review from a team as a code owner February 2, 2024 06:06
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2024
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 3, 2024
GaoleMeng
GaoleMeng reviewed Feb 6, 2024
View reviewed changes
...e-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
@@ -616,6 +616,8 @@ public static final class Builder {

private String traceId = null;

private String clientId = "java-streamwriter";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static final

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is settable.

...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java Outdated
@@ -228,7 +228,7 @@ public static final class Builder {

private Builder(SchemaAwareStreamWriter.Builder<Object> schemaAwareStreamWriterBuilder) {
this.schemaAwareStreamWriterBuilder =
schemaAwareStreamWriterBuilder.setTraceIdBase("JsonWriter");
schemaAwareStreamWriterBuilder.setClientId("java-jsonwriter");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to static final

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean this? In theory this can be set too but we just don't bother exposing it.

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@yirutang yirutang added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@yirutang yirutang merged commit 4258af4 into googleapis:main Feb 7, 2024
17 checks passed
@release-please release-please bot mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaoleMeng GaoleMeng GaoleMeng approved these changes

@kiraksi kiraksi Awaiting requested review from kiraksi kiraksi is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yirutang @GaoleMeng @yoshi-kokoro